Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code entities to be last time user/code was seen/used #83

Open
mattsaxon opened this issue Mar 4, 2022 · 4 comments
Open

Change code entities to be last time user/code was seen/used #83

mattsaxon opened this issue Mar 4, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@mattsaxon
Copy link
Collaborator

At the moment, there are codes entities for each user code and master.

There is no service code entity, though I believe there should be as some of the logged messages are relevant for the service code, for example entering elevated model.

Furthermore, the code entities, for my system never become active (my system is never set by code).

Looking at the python code, the intent appears to be that on setting of the system a code becomes active and on unsetting this would be cleared, I'm not sure if that makes sense given a different code could be used to set the system, from unset and this would leave the entities in a strange state.

Can you clarify what the intended behaviour of the code entities are?

@mattsaxon mattsaxon added the question Further information is requested label Mar 4, 2022
@tahvane1
Copy link
Owner

tahvane1 commented Mar 6, 2022

My system is very small and currently only one non-admin code is in use. (I think) I originally wanted to use code(s) as part of "presence" detector (more like is anyone present), but I have not realized that.

I agree that it is a bit problematic. If we want to just track code usage then it would be best to just active and (time delayed) clear. Another option would be to "track person who armed" and then we would need to clear all codes from unset (from any code).

@mattsaxon
Copy link
Collaborator Author

My proposal would be to change these entities to be the date/time the user was last seen.

@tahvane1
Copy link
Owner

tahvane1 commented Mar 7, 2022

sounds reasonable

@mattsaxon mattsaxon added enhancement New feature or request and removed question Further information is requested labels Mar 7, 2022
@mattsaxon mattsaxon changed the title What is expected behaviour of code entities? Change code entities to be last time user/code was seen/used Mar 7, 2022
@mattsaxon mattsaxon self-assigned this Mar 7, 2022
@mattsaxon mattsaxon removed their assignment Mar 8, 2022
@mattsaxon
Copy link
Collaborator Author

Also should add Service Code as an entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants