forked from aragon/taiko-contracts
-
Notifications
You must be signed in to change notification settings - Fork 15
/
Copy pathEmergencyMultisig.t.sol
2350 lines (1875 loc) · 89.5 KB
/
EmergencyMultisig.t.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;
import {AragonTest} from "./base/AragonTest.sol";
import {DaoBuilder} from "./helpers/DaoBuilder.sol";
import {StandardProposalCondition} from "../src/conditions/StandardProposalCondition.sol";
import {OptimisticTokenVotingPlugin} from "../src/OptimisticTokenVotingPlugin.sol";
import {Multisig} from "../src/Multisig.sol";
import {EmergencyMultisig} from "../src/EmergencyMultisig.sol";
import {IEmergencyMultisig} from "../src/interfaces/IEmergencyMultisig.sol";
import {DAO} from "@aragon/osx/core/dao/DAO.sol";
import {IDAO} from "@aragon/osx/core/dao/IDAO.sol";
import {PermissionManager} from "@aragon/osx/core/permission/PermissionManager.sol";
import {IProposal} from "@aragon/osx/core/plugin/proposal/IProposal.sol";
import {IPlugin} from "@aragon/osx/core/plugin/IPlugin.sol";
import {IMembership} from "@aragon/osx/core/plugin/membership/IMembership.sol";
import {Addresslist} from "@aragon/osx/plugins/utils/Addresslist.sol";
import {DaoUnauthorized} from "@aragon/osx/core/utils/auth.sol";
import {IERC165Upgradeable} from "@openzeppelin/contracts-upgradeable/utils/introspection/IERC165Upgradeable.sol";
import {createProxyAndCall} from "../src/helpers/proxy.sol";
uint64 constant EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD = 10 days;
contract EmergencyMultisigTest is AragonTest {
DaoBuilder builder;
DAO dao;
EmergencyMultisig eMultisig;
Multisig stdMultisig;
OptimisticTokenVotingPlugin optimisticPlugin;
// Events/errors to be tested here (duplicate)
event MultisigSettingsUpdated(
bool onlyListed, uint16 indexed minApprovals, Addresslist addresslistSource, uint64 expiration
);
event MembersAdded(address[] members);
event MembersRemoved(address[] members);
error InvalidAddresslistUpdate(address member);
error InvalidActions(uint256 proposalId);
// Multisig's event
event EmergencyProposalCreated(uint256 indexed proposalId, address indexed creator, bytes encryptedPayloadURI);
// OptimisticTokenVotingPlugin's event
event ProposalCreated(
uint256 indexed proposalId,
address indexed creator,
uint64 startDate,
uint64 endDate,
bytes metadata,
IDAO.Action[] actions,
uint256 allowFailureMap
);
event Approved(uint256 indexed proposalId, address indexed approver);
event Executed(uint256 indexed proposalId);
event Upgraded(address indexed implementation);
function setUp() public {
vm.startPrank(alice);
vm.warp(1 days);
vm.roll(100);
builder = new DaoBuilder();
(dao, optimisticPlugin, stdMultisig, eMultisig,,) = builder.withMultisigMember(alice).withMultisigMember(bob)
.withMultisigMember(carol).withMultisigMember(david).withMinApprovals(3).withMinDuration(0).build();
}
function test_RevertsIfTryingToReinitialize() public {
// Deploy a new stdMultisig instance
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
// Reinitialize should fail
vm.expectRevert("Initializable: contract is already initialized");
eMultisig.initialize(dao, settings);
}
function test_InitializeSetsMinApprovals() public {
// 2
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 2,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(, uint16 minApprovals,,) = eMultisig.multisigSettings();
assertEq(minApprovals, uint16(2), "Incorrect minApprovals");
// Redeploy with 1
settings.minApprovals = 1;
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(, minApprovals,,) = eMultisig.multisigSettings();
assertEq(minApprovals, uint16(1), "Incorrect minApprovals");
}
function test_InitializeSetsOnlyListed() public {
// Deploy with true
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(bool onlyListed,,,) = eMultisig.multisigSettings();
assertEq(onlyListed, true, "Incorrect onlyListed");
// Redeploy with false
settings.onlyListed = false;
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(onlyListed,,,) = eMultisig.multisigSettings();
assertEq(onlyListed, false, "Incorrect onlyListed");
}
function test_InitializeSetsAddresslistSource() public {
// Deploy the default stdMultisig as source
EmergencyMultisig.MultisigSettings memory emSettings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, emSettings))
)
);
(,, Addresslist givenAddressListSource,) = eMultisig.multisigSettings();
assertEq(address(givenAddressListSource), address(stdMultisig), "Incorrect addresslistSource");
// Redeploy with a new addresslist source
(,, Multisig newMultisig,,,) = builder.build();
emSettings.addresslistSource = newMultisig;
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, emSettings))
)
);
(,, givenAddressListSource,) = eMultisig.multisigSettings();
assertEq(address(givenAddressListSource), address(emSettings.addresslistSource), "Incorrect addresslistSource");
}
function test_InitializeSetsProposalExpiration() public {
// Deploy with 15 days
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: 15 days
});
address[] memory signers = new address[](4);
signers[0] = alice;
signers[1] = bob;
signers[2] = carol;
signers[3] = david;
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(,,, uint64 expirationPeriod) = eMultisig.multisigSettings();
assertEq(expirationPeriod, 15 days, "Incorrect expirationPeriod");
// Redeploy with 3 days
settings.proposalExpirationPeriod = 3 days;
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
(,,, expirationPeriod) = eMultisig.multisigSettings();
assertEq(expirationPeriod, 3 days, "Incorrect expirationPeriod");
}
function test_ShouldEmitMultisigSettingsUpdatedOnInstall() public {
// Deploy with true/3/default
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: 5 days
});
vm.expectEmit();
emit MultisigSettingsUpdated(true, uint16(3), stdMultisig, 5 days);
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
// Deploy with false/2/new
(,, Multisig newMultisig,,,) = builder.build();
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 2,
addresslistSource: newMultisig,
proposalExpirationPeriod: 15 days
});
vm.expectEmit();
emit MultisigSettingsUpdated(false, uint16(2), newMultisig, 15 days);
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
}
// INTERFACES
function test_DoesntSupportTheEmptyInterface() public view {
bool supported = eMultisig.supportsInterface(0);
assertEq(supported, false, "Should not support the empty interface");
}
function test_SupportsIERC165Upgradeable() public view {
bool supported = eMultisig.supportsInterface(type(IERC165Upgradeable).interfaceId);
assertEq(supported, true, "Should support IERC165Upgradeable");
}
function test_SupportsIPlugin() public view {
bool supported = eMultisig.supportsInterface(type(IPlugin).interfaceId);
assertEq(supported, true, "Should support IPlugin");
}
function test_SupportsIProposal() public view {
bool supported = eMultisig.supportsInterface(type(IProposal).interfaceId);
assertEq(supported, true, "Should support IProposal");
}
function test_SupportsIMembership() public view {
bool supported = eMultisig.supportsInterface(type(IMembership).interfaceId);
assertEq(supported, true, "Should support IMembership");
}
function test_SupportsIEmergencyMultisig() public view {
bool supported = eMultisig.supportsInterface(type(IEmergencyMultisig).interfaceId);
assertEq(supported, true, "Should support IEmergencyMultisig");
}
// UPDATE MULTISIG SETTINGS
function test_ShouldntAllowMinApprovalsHigherThenAddrListLength() public {
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 5,
addresslistSource: stdMultisig, // Greater than 4 members
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.MinApprovalsOutOfBounds.selector, 4, 5));
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
// Retry with onlyListed false
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 6,
addresslistSource: stdMultisig, // Greater than 4 members
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.MinApprovalsOutOfBounds.selector, 4, 6));
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
}
function test_ShouldNotAllowMinApprovalsZero() public {
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 0,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.MinApprovalsOutOfBounds.selector, 1, 0));
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
// Retry with onlyListed false
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 0,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.MinApprovalsOutOfBounds.selector, 1, 0));
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
}
function test_ShouldEmitMultisigSettingsUpdated() public {
dao.grant(address(eMultisig), address(alice), eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
// 1
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 1,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectEmit();
emit MultisigSettingsUpdated(true, 1, stdMultisig, EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD);
eMultisig.updateMultisigSettings(settings);
// 2
(,, Multisig newMultisig,,,) = builder.build();
settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 2,
addresslistSource: newMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD - 1
});
vm.expectEmit();
emit MultisigSettingsUpdated(true, 2, newMultisig, EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD - 1);
eMultisig.updateMultisigSettings(settings);
// 3
(,, newMultisig,,,) = builder.build();
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 3,
addresslistSource: newMultisig,
proposalExpirationPeriod: 4 days
});
vm.expectEmit();
emit MultisigSettingsUpdated(false, 3, newMultisig, 4 days);
eMultisig.updateMultisigSettings(settings);
// 4
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 4,
addresslistSource: stdMultisig,
proposalExpirationPeriod: 8 days
});
vm.expectEmit();
emit MultisigSettingsUpdated(false, 4, stdMultisig, 8 days);
eMultisig.updateMultisigSettings(settings);
}
function test_UpdateSettingsShouldRevertWithInvalidAddressSource() public {
dao.grant(address(eMultisig), alice, eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
// ko
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
addresslistSource: Multisig(address(dao)),
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.InvalidAddressListSource.selector, address(dao)));
eMultisig.updateMultisigSettings(settings);
// ko 2
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
addresslistSource: Multisig(address(optimisticPlugin)),
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(
abi.encodeWithSelector(EmergencyMultisig.InvalidAddressListSource.selector, address(optimisticPlugin))
);
eMultisig.updateMultisigSettings(settings);
// ok
(,, Multisig newMultisig,,,) = builder.build();
settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
addresslistSource: newMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig.updateMultisigSettings(settings);
}
function test_onlyWalletWithPermissionsCanUpdateSettings() public {
(,, Multisig newMultisig,,,) = builder.build();
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
addresslistSource: newMultisig,
proposalExpirationPeriod: 3 days
});
vm.expectRevert(
abi.encodeWithSelector(
DaoUnauthorized.selector,
address(dao),
address(eMultisig),
alice,
eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID()
)
);
eMultisig.updateMultisigSettings(settings);
// Nothing changed
(bool onlyListed, uint16 minApprovals, Addresslist currentSource, uint64 expiration) =
eMultisig.multisigSettings();
assertEq(onlyListed, true);
assertEq(minApprovals, 3);
assertEq(address(currentSource), address(stdMultisig));
assertEq(expiration, 10 days);
// Retry with the permission
dao.grant(address(eMultisig), alice, eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
vm.expectEmit();
emit MultisigSettingsUpdated(false, 1, newMultisig, 3 days);
eMultisig.updateMultisigSettings(settings);
}
function test_IsMemberShouldReturnWhenApropriate() public {
assertEq(eMultisig.isMember(alice), true, "Should be a member");
assertEq(eMultisig.isMember(bob), true, "Should be a member");
assertEq(eMultisig.isMember(carol), true, "Should be a member");
assertEq(eMultisig.isMember(david), true, "Should be a member");
dao.grant(address(stdMultisig), alice, stdMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
address[] memory signers = new address[](1);
signers[0] = bob;
stdMultisig.removeAddresses(signers);
assertEq(eMultisig.isMember(alice), true, "Should be a member");
assertEq(eMultisig.isMember(bob), false, "Should not be a member");
assertEq(eMultisig.isMember(carol), true, "Should be a member");
assertEq(eMultisig.isMember(david), true, "Should be a member");
// 2
stdMultisig.addAddresses(signers); // Add Bob back
signers[0] = alice;
stdMultisig.removeAddresses(signers);
assertEq(eMultisig.isMember(alice), false, "Should not be a member");
assertEq(eMultisig.isMember(bob), true, "Should be a member");
assertEq(eMultisig.isMember(carol), true, "Should be a member");
assertEq(eMultisig.isMember(david), true, "Should be a member");
// 3
stdMultisig.addAddresses(signers); // Add Alice back
signers[0] = carol;
stdMultisig.removeAddresses(signers);
assertEq(eMultisig.isMember(alice), true, "Should be a member");
assertEq(eMultisig.isMember(bob), true, "Should be a member");
assertEq(eMultisig.isMember(carol), false, "Should not be a member");
assertEq(eMultisig.isMember(david), true, "Should be a member");
// 4
stdMultisig.addAddresses(signers); // Add Carol back
signers[0] = david;
stdMultisig.removeAddresses(signers);
assertEq(eMultisig.isMember(alice), true, "Should be a member");
assertEq(eMultisig.isMember(bob), true, "Should be a member");
assertEq(eMultisig.isMember(carol), true, "Should be a member");
assertEq(eMultisig.isMember(david), false, "Should not be a member");
}
function test_IsMemberIsListedShouldReturnTheSameValue() public {
assertEq(stdMultisig.isListed(alice), eMultisig.isMember(alice), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(bob), eMultisig.isMember(bob), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(carol), eMultisig.isMember(carol), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(david), eMultisig.isMember(david), "isMember isListed should be equal");
dao.grant(address(stdMultisig), alice, stdMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
address[] memory signers = new address[](1);
signers[0] = alice;
stdMultisig.removeAddresses(signers);
assertEq(stdMultisig.isListed(alice), eMultisig.isMember(alice), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(bob), eMultisig.isMember(bob), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(carol), eMultisig.isMember(carol), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(david), eMultisig.isMember(david), "isMember isListed should be equal");
// 2
stdMultisig.addAddresses(signers); // Add Alice back
signers[0] = bob;
stdMultisig.removeAddresses(signers);
assertEq(stdMultisig.isListed(alice), eMultisig.isMember(alice), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(bob), eMultisig.isMember(bob), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(carol), eMultisig.isMember(carol), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(david), eMultisig.isMember(david), "isMember isListed should be equal");
// 3
stdMultisig.addAddresses(signers); // Add Bob back
signers[0] = carol;
stdMultisig.removeAddresses(signers);
assertEq(stdMultisig.isListed(alice), eMultisig.isMember(alice), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(bob), eMultisig.isMember(bob), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(carol), eMultisig.isMember(carol), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(david), eMultisig.isMember(david), "isMember isListed should be equal");
// 4
stdMultisig.addAddresses(signers); // Add Carol back
signers[0] = david;
stdMultisig.removeAddresses(signers);
assertEq(stdMultisig.isListed(alice), eMultisig.isMember(alice), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(bob), eMultisig.isMember(bob), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(carol), eMultisig.isMember(carol), "isMember isListed should be equal");
assertEq(stdMultisig.isListed(david), eMultisig.isMember(david), "isMember isListed should be equal");
}
function testFuzz_IsMemberIsFalseByDefault(uint256 _randomEntropy) public {
// Deploy a new stdMultisig instance
Multisig.MultisigSettings memory mSettings = Multisig.MultisigSettings({
onlyListed: true,
minApprovals: 1,
destinationProposalDuration: 4 days,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
address[] memory signers = new address[](1);
signers[0] = address(0x0); // 0x0... would be a member but the chance is negligible
stdMultisig = Multisig(
createProxyAndCall(address(MULTISIG_BASE), abi.encodeCall(Multisig.initialize, (dao, signers, mSettings)))
);
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 1,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
assertEq(
eMultisig.isMember(vm.addr(uint256(keccak256(abi.encodePacked(_randomEntropy))))), false, "Should be false"
);
}
function testFuzz_PermissionedUpdateSettings(address randomAccount) public {
dao.grant(address(eMultisig), alice, eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
(bool onlyListed, uint16 minApprovals, Addresslist addresslistSource, uint64 expiration) =
eMultisig.multisigSettings();
assertEq(minApprovals, 3, "Should be 3");
assertEq(onlyListed, true, "Should be true");
assertEq(address(addresslistSource), address(stdMultisig), "Incorrect addresslistSource");
assertEq(expiration, 10 days, "Should be 10");
// in
(,, Multisig newMultisig,,,) = builder.build();
EmergencyMultisig.MultisigSettings memory newSettings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 2,
addresslistSource: newMultisig,
proposalExpirationPeriod: 4 days
});
eMultisig.updateMultisigSettings(newSettings);
Addresslist givenAddresslistSource;
(onlyListed, minApprovals, givenAddresslistSource, expiration) = eMultisig.multisigSettings();
assertEq(minApprovals, 2, "Should be 2");
assertEq(onlyListed, false, "Should be false");
assertEq(address(givenAddresslistSource), address(newMultisig), "Incorrect addresslistSource");
assertEq(expiration, 4 days, "Should be 4");
// out
newSettings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 1,
addresslistSource: stdMultisig,
proposalExpirationPeriod: 1 days
});
eMultisig.updateMultisigSettings(newSettings);
(onlyListed, minApprovals, givenAddresslistSource, expiration) = eMultisig.multisigSettings();
assertEq(minApprovals, 1, "Should be 1");
assertEq(onlyListed, true, "Should be true");
assertEq(address(givenAddresslistSource), address(stdMultisig), "Incorrect addresslistSource");
assertEq(expiration, 1 days, "Should be 1");
vm.roll(block.number + 1);
// someone else
if (randomAccount != alice && randomAccount != address(0)) {
vm.startPrank(randomAccount);
(,, newMultisig,,,) = builder.build();
newSettings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 4,
addresslistSource: newMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
vm.expectRevert(
abi.encodeWithSelector(
DaoUnauthorized.selector,
address(dao),
address(eMultisig),
randomAccount,
eMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID()
)
);
eMultisig.updateMultisigSettings(newSettings);
(onlyListed, minApprovals, givenAddresslistSource, expiration) = eMultisig.multisigSettings();
assertEq(minApprovals, 1, "Should still be 1");
assertEq(onlyListed, true, "Should still be true");
assertEq(address(givenAddresslistSource), address(stdMultisig), "Should still be stdMultisig");
assertEq(expiration, 1 days, "Should still be 1");
}
}
// PROPOSAL CREATION
function test_IncrementsTheProposalCounter() public {
// increments the proposal counter
assertEq(eMultisig.proposalCount(), 0, "Should have no proposals");
// 1
eMultisig.createProposal(
"ipfs://",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
false
);
assertEq(eMultisig.proposalCount(), 1, "Should have 1 proposal");
// 2
eMultisig.createProposal(
"ipfs://more",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true
);
assertEq(eMultisig.proposalCount(), 2, "Should have 2 proposals");
}
function test_CreatesAndReturnsUniqueProposalIds() public {
// creates unique proposal IDs for each proposal
// 1
uint256 pid = eMultisig.createProposal(
"",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true
);
assertEq(pid, 0, "Should be 0");
// 2
pid = eMultisig.createProposal(
"ipfs://",
bytes32(0x0000567800000000000000000000000000000000000000000000000000000000),
bytes32(0x0000000056780000000000000000000000000000000000000000000000000000),
optimisticPlugin,
false
);
assertEq(pid, 1, "Should be 1");
// 3
pid = eMultisig.createProposal(
"ipfs://more",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000000012340000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true
);
assertEq(pid, 2, "Should be 2");
}
function test_EmitsProposalCreated() public {
// emits the `ProposalCreated` event
vm.expectEmit();
emit EmergencyProposalCreated({proposalId: 0, creator: alice, encryptedPayloadURI: ""});
eMultisig.createProposal(
"",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true
);
// 2
vm.startPrank(bob);
vm.expectEmit();
emit EmergencyProposalCreated({proposalId: 1, creator: bob, encryptedPayloadURI: "ipfs://"});
eMultisig.createProposal(
"ipfs://",
bytes32(0x0000567800000000000000000000000000000000000000000000000000000000),
bytes32(0x0000000056780000000000000000000000000000000000000000000000000000),
optimisticPlugin,
false
);
}
function test_RevertsIfSettingsChangedInSameBlock() public {
// reverts if the stdMultisig settings have changed in the same block
{
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: true,
minApprovals: 3,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
}
// Same block
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.ProposalCreationForbidden.selector, alice));
eMultisig.createProposal("", bytes32(0), bytes32(0), optimisticPlugin, false);
// Next block
vm.roll(block.number + 1);
eMultisig.createProposal("", bytes32(0), bytes32(0), optimisticPlugin, false);
}
function test_CreatesWhenUnlistedAccountsAllowed() public {
// creates a proposal when unlisted accounts are allowed
// Deploy a new instance with custom settings
(dao, optimisticPlugin, stdMultisig, eMultisig,,) = builder.withoutOnlyListed().build();
vm.startPrank(randomWallet);
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
vm.startPrank(carol);
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
vm.startPrank(david);
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
}
function test_RevertsWhenOnlyListedAndAnotherWalletCreates() public {
// reverts if the user is not on the list and only listed accounts can create proposals
vm.startPrank(randomWallet);
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.ProposalCreationForbidden.selector, randomWallet));
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
vm.startPrank(taikoBridge);
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.ProposalCreationForbidden.selector, taikoBridge));
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
}
function test_RevertsWhenCreatorWasListedBeforeButNotNow() public {
// reverts if `msg.sender` is not listed although she was listed in the last block
dao.grant(address(stdMultisig), alice, stdMultisig.UPDATE_MULTISIG_SETTINGS_PERMISSION_ID());
// Remove
address[] memory addrs = new address[](1);
addrs[0] = alice;
stdMultisig.removeAddresses(addrs);
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.ProposalCreationForbidden.selector, alice));
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
stdMultisig.addAddresses(addrs); // Add Alice back
vm.roll(block.number + 1);
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
// Add+remove
addrs[0] = bob;
stdMultisig.removeAddresses(addrs);
vm.startPrank(bob);
// Bob cannot create now
vm.expectRevert(abi.encodeWithSelector(EmergencyMultisig.ProposalCreationForbidden.selector, bob));
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
vm.startPrank(alice);
// Bob can create now
stdMultisig.addAddresses(addrs); // Add Bob back
vm.startPrank(alice);
eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
}
function test_CreatesProposalWithoutApprovingIfUnspecified() public {
// creates a proposal successfully and does not approve if not specified
uint256 pid = eMultisig.createProposal(
"",
0,
0,
optimisticPlugin,
false // approveProposal
);
assertEq(eMultisig.hasApproved(pid, alice), false, "Should not have approved");
(, uint16 approvals,,,,,) = eMultisig.getProposal(pid);
assertEq(approvals, 0, "Should be 0");
eMultisig.approve(pid);
assertEq(eMultisig.hasApproved(pid, alice), true, "Should have approved");
(, approvals,,,,,) = eMultisig.getProposal(pid);
assertEq(approvals, 1, "Should be 1");
}
function test_CreatesAndApprovesWhenSpecified() public {
// creates a proposal successfully and approves if specified
vm.expectEmit();
emit Approved({proposalId: 0, approver: alice});
eMultisig.createProposal(
"ipfs://",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true
);
uint256 pid = eMultisig.createProposal(
"ipfs://",
bytes32(0x1234000000000000000000000000000000000000000000000000000000000000),
bytes32(0x0000123400000000000000000000000000000000000000000000000000000000),
optimisticPlugin,
true // approveProposal
);
assertEq(eMultisig.hasApproved(pid, alice), true, "Should have approved");
(, uint16 approvals,,,,,) = eMultisig.getProposal(pid);
assertEq(approvals, 1, "Should be 1");
}
function test_HashActionsReturnsProperData() public view {
IDAO.Action[] memory actions = new IDAO.Action[](1);
actions[0].to = address(dao);
actions[0].value = 1 ether;
actions[0].data = hex"00112233";
bytes32 h1 = eMultisig.hashActions(actions);
// 2
actions[0].to = bob;
bytes32 h2 = eMultisig.hashActions(actions);
assertNotEq(h1, h2, "Hashes should differ");
// 3
actions[0].value = 2 ether;
bytes32 h3 = eMultisig.hashActions(actions);
assertNotEq(h2, h3, "Hashes should differ");
// 4
actions[0].data = hex"00112235";
bytes32 h4 = eMultisig.hashActions(actions);
assertNotEq(h3, h4, "Hashes should differ");
// 5
actions = new IDAO.Action[](0);
bytes32 h5 = eMultisig.hashActions(actions);
assertNotEq(h4, h5, "Hashes should differ");
// 5'
bytes32 h5b = eMultisig.hashActions(actions);
assertEq(h5, h5b, "Hashes should match");
}
// CAN APPROVE
function testFuzz_CanApproveReturnsfFalseIfNotCreated(uint256 randomProposalId) public view {
// returns `false` if the proposal doesn't exist
assertEq(eMultisig.canApprove(randomProposalId, alice), false, "Should be false");
assertEq(eMultisig.canApprove(randomProposalId, bob), false, "Should be false");
assertEq(eMultisig.canApprove(randomProposalId, carol), false, "Should be false");
assertEq(eMultisig.canApprove(randomProposalId, david), false, "Should be false");
}
function testFuzz_CanApproveReturnsfFalseIfNotListed(address randomWallet) public {
// returns `false` if the approver is not listed
{
// Leaving the deployment for fuzz efficiency
// Deploy a new stdMultisig instance
Multisig.MultisigSettings memory mSettings = Multisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
destinationProposalDuration: 4 days,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
address[] memory signers = new address[](1);
signers[0] = address(0x0);
stdMultisig = Multisig(
createProxyAndCall(
address(MULTISIG_BASE), abi.encodeCall(Multisig.initialize, (dao, signers, mSettings))
)
);
// New emergency stdMultisig using the above
EmergencyMultisig.MultisigSettings memory settings = EmergencyMultisig.MultisigSettings({
onlyListed: false,
minApprovals: 1,
addresslistSource: stdMultisig,
proposalExpirationPeriod: EMERGENCY_MULTISIG_PROPOSAL_EXPIRATION_PERIOD
});
eMultisig = EmergencyMultisig(
createProxyAndCall(
address(EMERGENCY_MULTISIG_BASE), abi.encodeCall(EmergencyMultisig.initialize, (dao, settings))
)
);
vm.roll(block.number + 1);
}
uint256 pid = eMultisig.createProposal("", 0, 0, optimisticPlugin, false);
// ko
if (randomWallet != address(0x0)) {
assertEq(eMultisig.canApprove(pid, randomWallet), false, "Should be false");
}