From 93ef06ba5fdf9f6108d1fd99026884a7eaba10a1 Mon Sep 17 00:00:00 2001
From: Einar Rasmussen <einar@taiko.xyz>
Date: Mon, 28 Aug 2023 13:40:41 +0800
Subject: [PATCH] refactor:  Implement partial review suggestions

---
 src/derive/curve.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/derive/curve.rs b/src/derive/curve.rs
index 889e5f90..14eba46f 100644
--- a/src/derive/curve.rs
+++ b/src/derive/curve.rs
@@ -746,15 +746,21 @@ macro_rules! new_curve_impl {
                 let zz1 = p.zz;
                 let zzz1 = p.zzz;
 
+                // curve constants
+                const A: $base = $name_jac_ext::curve_constant_a();
+                debug_assert_eq!(A, $base::zero());
+
                 // intermediates
                 let u = y1.double();
                 let v = u.square();
                 let w = u*v;
                 let s = x1 * v;
                 let x1_sqr = x1.square();
+
                 // For the curves we use, the curve constant `a` is always zero,
                 // so we can leave out the last term.
-                let m = (x1_sqr.double()+x1_sqr); // + a*zz1.square();
+                // was: let m = x1_sqr.double()+x1_sqr + A*zz1.square();
+                let m = x1_sqr.double()+x1_sqr;
 
                 // p+p
                 let x3 = m.square() - s.double();