Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

Get rid of OrderedDicts #233

Open
sr-gi opened this issue Sep 23, 2020 · 6 comments
Open

Get rid of OrderedDicts #233

sr-gi opened this issue Sep 23, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@sr-gi
Copy link
Member

sr-gi commented Sep 23, 2020

The minimum required Python version will be bumped to 3.7 with release v0.1.1.

With Python 3.7, dicts preserve inclusion order, so there will be no need for OrderedDicts anymore within the codebase (given that the former are much faster).

@sr-gi sr-gi added enhancement New feature or request good first issue Good for newcomers labels Sep 23, 2020
@sr-gi sr-gi added this to the v0.2.0 milestone Sep 23, 2020
@cedric-audy
Copy link

I could do that, if no one has started yet

@sr-gi
Copy link
Member Author

sr-gi commented Nov 12, 2020

Welcome @cedric-audy, feel free to take it, no one is working on this atm.

@ritikramuka
Copy link

@cedric-audy are you working on this? or may I begin working on it now?

@ritikramuka
Copy link

hi there, @sr-gi I searched the codebase for the term OrderedDicts but couldn't find it.
So, could you please advise me on how to proceed?

@sr-gi
Copy link
Member Author

sr-gi commented Feb 22, 2022

Hi @ritikramuka, happy to see you're showing interest to contribute to teos.

The only instances of OrderedDict in the codebase should be in the LocatorCache located in the Watcher.

I wanted to let you known, though, that this codebase will be deprecated in the upcoming weeks, in favor of https://github.com/sr-gi/rusty-teos (the Rust port of it).

I'm planning on tackling some issues in this Python version and leave it at a final stable version, but all future development may only take place in rust-teos.

Having said that, you're welcome to tackle this if you'd like to get familiar with the codebase, and more than welcome to contribute to rust-teos once the first alpha is released.

@ritikramuka
Copy link

Hi @sr-gi I tried to install all the requirements listed in CONTRIBUTING.md but running pytest gives the below

test/common/unit/conftest.py:5: in <module>
    from common.db_manager import DBManager
common/db_manager.py:2: in <module>
    import plyvel
E   ModuleNotFoundError: No module named 'plyvel'

then I tried installing requirements.txt which contains plyvel package but got this error

ERROR: Failed building wheel for plyvel

ritikramuka added a commit to ritikramuka/python-teos that referenced this issue Feb 23, 2022
ritikramuka added a commit to ritikramuka/python-teos that referenced this issue Feb 24, 2022
ritikramuka added a commit to ritikramuka/python-teos that referenced this issue Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants