Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR-23489] [Documentation] Fix indentation #351

Merged
merged 5 commits into from
Jan 21, 2025
Merged

[PR-23489] [Documentation] Fix indentation #351

merged 5 commits into from
Jan 21, 2025

Conversation

Buritos16
Copy link
Contributor

@Buritos16 Buritos16 commented Jan 9, 2025

README.md Outdated
#### General Formatting Rules

1. **Directives (`..` syntax)**:
- All directives starting with `..` (e.g., `.. image::`, `.. note::`) must have **2 spaces** indentation for their content. Examples:
Copy link
Member

@zhuravel zhuravel Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose 2 spaces? I prefer 3 and this what we most commonly have.
I chose 3 because that’s what RST documentation uses everywhere and what looks best.
https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html

cc @wrimer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the reStructuredText (RST) documentation, there are no strict rules mandating the use of 2 or 3 spaces for indentation. In our project, I didn’t see a significant advantage to using 3 spaces.

Therefore, I decided to standardize on 2 spaces because it’s the minimal value and the quickest to write.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Buritos16 Okay. You still have 3 spaces here:

https://github.com/talkable/talkable-docs/blob/4f74b18f26d699ac2aceba2a0dace30a79812fec/source/advanced_features/google_login.rst#L87-L88
https://github.com/talkable/talkable-docs/blob/4f74b18f26d699ac2aceba2a0dace30a79812fec/source/advanced_features/passing_custom_data.rst#L82-L85
https://github.com/talkable/talkable-docs/blob/4f74b18f26d699ac2aceba2a0dace30a79812fec/source/campaigns/editor/videos.rst#L47-L49
https://github.com/talkable/talkable-docs/blob/4f74b18f26d699ac2aceba2a0dace30a79812fec/source/integration/ecommerce_platforms/shopify.rst#L313-L315
https://github.com/talkable/talkable-docs/blob/4f74b18f26d699ac2aceba2a0dace30a79812fec/source/partials/common.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuravel If needed, I can switch to 3 spaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch those places I’ve mentioned to 2 spaces as everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated Show resolved Hide resolved
Copy link
Member

@zhuravel zhuravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces → 3 spaces

@Buritos16 Buritos16 requested a review from zhuravel January 15, 2025 16:26
@zhuravel zhuravel added the LG Looks good label Jan 15, 2025
@Buritos16 Buritos16 merged commit 444e705 into master Jan 21, 2025
1 check passed
@Buritos16 Buritos16 deleted the rt-PR-23489 branch January 21, 2025 13:24
Buritos16 added a commit that referenced this pull request Jan 21, 2025
Author: Roman Typylo <[email protected]>

    [PR-23489] [Documentation] Fix indentation (#351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LG Looks good
Development

Successfully merging this pull request may close these issues.

4 participants