Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user.media_set_volume is called but never declared #1491

Open
priggins2 opened this issue Jul 11, 2024 · 4 comments
Open

user.media_set_volume is called but never declared #1491

priggins2 opened this issue Jul 11, 2024 · 4 comments

Comments

@priggins2
Copy link

There seems to be a function missing in community: user.media_set_volume is called in media.talon but isn’t declared anywhere

@fidgetingbits
Copy link
Collaborator

git blame suggests it was from dwiel, who has this in their repo

https://github.com/dwiel/knausj_talon/blob/f2263040a71f711b43d0949311c959fe68a7dd7b/code/media.py#L9

Is mac only though

@phillco
Copy link
Collaborator

phillco commented Jul 12, 2024

Should we bring that over, for Mac? I think that's the best way to set it, if there's not a Talon API

@fidgetingbits
Copy link
Collaborator

Ya seems reasonable, not sure about windows, but on linux there is a similar pulse audio command which hopefully would work on most distros.

@phillco
Copy link
Collaborator

phillco commented Jul 12, 2024

It looks like we can also read and set the mute status directly (rather than just sending the keyboard button to toggle it). Although since this won't show the OSD indicator, we probably don't want to use it by default.

$ osascript -e "get volume settings"
output volume:44, input volume:75, alert volume:34, output muted:false
$ osascript -e "set volume output muted true"
$ osascript -e "set volume output muted false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants