Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve unnamed peaks set without raising Error when creating McPeaks object from McCounts #52

Open
tomgome opened this issue Jul 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tomgome
Copy link
Contributor

tomgome commented Jul 13, 2022

if a valid peaks interval set is passed (i.e. has 'chrom','start','end'), but lacking peak_name column - call peak_names() internally to solve this issue, instead of aborting:

peak_set = fread('path/to/peak/file.txt')

mcatac_obj <- mcc_to_mcatac(mcc, peaks = peak_set, metadata = mc_md)
Error in `mcc_to_mcatac()`:
! The `peaks` must have a column called peak_name

Solution:
if(!has_name(peak_set)){ peak_set$peak_name = peak_names(peak_set) }

@tomgome tomgome added the enhancement New feature or request label Jul 13, 2022
aviezerl added a commit that referenced this issue Jul 14, 2022
fixes solve unnamed peaks set without raising Error when creating McPeaks object from McCounts #52
@aviezerl
Copy link
Contributor

Fixed in the shiny-app branch. The issue would be closed when it would be merged.

ofirr pushed a commit that referenced this issue Jan 2, 2024
fixes solve unnamed peaks set without raising Error when creating McPeaks object from McCounts #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants