Update number of shells in SimulationState

[DeerWhale]

📝 Description

Type: 🪲 bugfix | 🚦 testing

Update the no_of_shells attribute in SimulationState to be the no_of_shells_active in geometry.
This can make sure the dimensionality of the attributes in the SimulationState is consistent with the activate shells after changing the v_inner_boundary value on fly.

📌 Resources

🚦 Testing

How did you test these changes?

• Testing pipeline
• Other method (describe)
• My changes can't be tested (explain why)

☑️ Checklist

• I requested two reviewers for this pull request
• I updated the documentation according to my changes
• I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

[andrewfullard]

These changes in model/base.py may be replaced by work @wkerzendorf is doing. Or this should be merged into #2445

[wkerzendorf]

@DeerWhale the tests fail.

[tardis-bot]

*beep* *bop*

Hi, human.

The docs workflow has failed ❌

Click here to see the build log.

[Rodot-]

Is there any update on this? I believe CSVY models are still broken until this is merged.

[DeerWhale]

Closing this duplicated one -- the (almost) same edits is made in a new PR #2504 after the restructure.