Restructure/separate transport state #2492
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,334 @@ | |||
| import warnings | |||
There was a problem hiding this comment.
This might be a bit only a minor detail, but I would name this file montecarlo_transport_state.py as it only contains the MonteCarloTransportState class.
| actual = getattr(simulation_one_loop.simulation_state, name) | ||
| if name in ["t_radiative", "output_nu", "output_energy"]: | ||
| elif name in ["output_nu", "output_energy"]: | ||
| OLD_TO_NEW_DICT = { |
There was a problem hiding this comment.
I assume this is a way to handle the old naming?
There was a problem hiding this comment.
I think it is - but I would have to look closer.
thanks - that is the plan 😄 |
|
*beep* *bop* Hi, human. The Click here to see your results. |
andrewfullard
force-pushed
the
restructure/separate_transport_state
branch
from
64e2b0c to
ca18310
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2492 +/- ##
==========================================
+ Coverage 68.46% 68.63% +0.17%
==========================================
Files 159 159
Lines 13719 13749 +30
==========================================
+ Hits 9393 9437 +44
+ Misses 4326 4312 -14 ☔ View full report in Codecov by Sentry. |
Now located in the MCTState. Tests are still failing!
Spectra and scalars need a different testing method, out of scope for this PR.
Needs to merge #2476 before this one