[DNM] Hero Graph remove old block for new block #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krakaw
requested changes
Jun 23, 2020
Thanks @Krakaw. I've moved it to the API call. |
Krakaw
requested changes
Jun 23, 2020
| @@ -13,6 +13,7 @@ const config = { | |||
| process.env.REACT_APP_EXPLORER_API_DOMAIN + '/ws' | |||
| ), | |||
| tokenName: process.env.REACT_APP_TOKEN_NAME || 'tXTR', | |||
| initialBlockCount: +(process.env.REACT_APP_INITIAL_BLOCK_COUNT || 100) | |||
| initialBlockCount: +(process.env.REACT_APP_INITIAL_BLOCK_COUNT || 100), | |||
| maxBlocks: +(process.env.REACT_APP_MAX_BLOCKS || 100) | |||
There was a problem hiding this comment.
Add the env to the .env.sample file
Comment on lines
+29
to
+31
| if(blocks.blocks.length > config.maxBlocks) { | ||
| blocks.blocks.splice(-1,1); | ||
| } |
There was a problem hiding this comment.
Move this to the redux action. Also how do we know that we only need to reduce by 1? We could've fetched 200 blocks.
schmentle
changed the title
|
@msbodetti any chance you could please take care of @Krakaw's feedback? Then I'll get this approved and merged - it's a definite improvement! |
|
Awesome thanks! There's no rush 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the explorer is opened, new blocks will keep rolling in and the graph becomes unreadable.
Screencast
https://share.getcloudapp.com/E0uzYYjj
Closes: #70