Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemoryBroker startup method does not call result_backend's startup method #291

Open
matiaskotlik opened this issue Feb 14, 2024 · 1 comment

Comments

@matiaskotlik
Copy link

The InMemoryBroker bundled in taskiq does not call startup() on its result_backend.

The default result_backend for InMemoryBroker (InmemoryResultBackend) does not implement startup() so if you do not override the result_backend with with_result_backend(), this bug has no effect.

Using any other result backend (that implements startup()) with the InMemoryBroker will have unexpected results since startup() will never get called on the result backend.

It's a one line fix. Great first PR for any beginner. I will push a fix later this week if no one beats me to it.

@s3rius
Copy link
Member

s3rius commented Feb 15, 2024

Please do it. Any contribution is valuable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants