Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] .msi bundle not working properly #12391

Closed
SauvageThomas opened this issue Jan 13, 2025 · 4 comments · Fixed by #12402
Closed

[bug] .msi bundle not working properly #12391

SauvageThomas opened this issue Jan 13, 2025 · 4 comments · Fixed by #12402
Assignees
@FabianLars
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@SauvageThomas
Copy link

Describe the bug

During the windows bundle, I want to copy a .dll along the .exe.

I tested a lot of configurations when the .dll should be with the .exe, the .dll is completly missing from the installation directory. When the .dll is inside a directory it works without issue.

It works with the .nsis, but not with the .msi.

Reproduction

In tauri.conf.json I add this inside the bundle property:

"resources": {
      "dll/opencv_world4110.dll": "opencv_world4110.dll"
}

or

"resources": [
      "opencv_world4110.dll"
]

Then, I run

yarn tauri build

Expected behavior

My dll should be with the .exe in Program Files.

Full tauri info output

[✔] Environment
    - OS: Windows 10.0.26100 x86_64 (X64)
    ✔ WebView2: 131.0.2903.112
    ✔ MSVC: Visual Studio Build Tools 2019
    ✔ rustc: 1.83.0 (90b35a623 2024-11-26)
    ✔ cargo: 1.83.0 (5ffbef321 2024-10-29)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 22.13.0
    - pnpm: 9.1.2
    - yarn: 1.22.22
    - npm: 10.9.2

[-] Packages
    - tauri 🦀: 2.2.1
    - tauri-build 🦀: 2.0.5
    - wry 🦀: 0.48.0
    - tao 🦀: 0.31.1
    - tauri-cli 🦀: 2.0.0-beta.22
    - @tauri-apps/api : 2.2.0
    - @tauri-apps/cli : 2.2.2

[-] Plugins
    - tauri-plugin-dialog 🦀: 2.2.0
    - @tauri-apps/plugin-dialog : not installed!
    - tauri-plugin-sql 🦀: 2.2.0
    - @tauri-apps/plugin-sql : not installed!
    - tauri-plugin-single-instance 🦀: 2.2.0
    - @tauri-apps/plugin-single-instance : not installed!
    - tauri-plugin-fs 🦀: 2.2.0
    - @tauri-apps/plugin-fs : not installed!

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: Vue.js
    - bundler: Vite

Stack trace

No response

Additional context

No response
@SauvageThomas SauvageThomas added status: needs triage This issue needs to triage, applied to new issues type: bug labels Jan 13, 2025
@FabianLars FabianLars self-assigned this Jan 14, 2025
@FabianLars
Copy link
Member

For #12324 i tested the msi and at least the WebView2Loader.dll was included correctly (only happens with the gnu toolchain). That doesn't use the resources feature though so maybe there's a timing issue or something.
I'll look into it :)

@FabianLars
Copy link
Member

@SauvageThomas Can you try this please?

cargo install tauri-cli --debug --git https://github.com/tauri-apps/tauri --branch fix/bundler-dlls
cargo tauri build

@SauvageThomas
Copy link
Author

@FabianLars, thanks for the quick update. I just tested and it works ! Thank you a lot.

@FabianLars
Copy link
Member

nice, thanks for trying it.

@FabianLars FabianLars mentioned this issue Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabianLars FabianLars

Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bundler/wix): Prevent dlls from overwriting root resources tauri-apps/tauri
2 participants
@SauvageThomas @FabianLars