Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add deprecation warning for updater.dialog: true in v1 #12457

Open
FabianLars opened this issue Jan 20, 2025 · 0 comments
Open

[feat] Add deprecation warning for updater.dialog: true in v1 #12457

FabianLars opened this issue Jan 20, 2025 · 0 comments

Comments

@FabianLars
Copy link
Member

Describe the problem

In v2 we somewhat quietly got rid of the built-in dialog. This is especially unexpected for devs that didn't set the updater.dialog config at all because it defaulted to true hiding the fact that no config in v2 is vastly different in behavior.

For example one dev on discord updated many of their users to a v2 version of their app and now just noticed that those users can't receive any further updates. Very very unfortunate situation...

Describe the solution you'd like

The cli and/or compiler should print warnings.

Alternatives considered

I've already updated the migration docs with a bit of color to make this more apparent.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant