You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using addPluginListener, I found that registerListener is not allowed. Upon further investigation, I discovered that addPluginListener internally uses registerListener. I believe this does not conform to Rust's naming conventions, and it should be corrected to the previous register_listener.
I believe this does not conform to Rust's naming conventions
does that matter considering that rust isn't really involved here? There's no registerListener / register_listener function in rust, only in kotlin / swift.
I am not clear about the rationale behind this change. I would appreciate it if I could receive a response explaining the reasoning.
Imo it was the less breaking way to hotfix it. ref #8068 / #10196
That said, i don't know why this is the only function that does not follow snake_case naming convention (even compared to its direct counterpart remove_listener) either. Maybe @lucasfernog knows if he looked into that for the PR 🤷
If this is fixable this should really wait until the next major of course.
I believe this does not conform to Rust's naming conventions
does that matter considering that rust isn't really involved here? There's no registerListener / register_listener function in rust, only in kotlin / swift.
I am not clear about the rationale behind this change. I would appreciate it if I could receive a response explaining the reasoning.
Imo it was the less breaking way to hotfix it. ref #8068 / #10196
That said, i don't know why this is the only function that does not follow snake_case naming convention (even compared to its direct counterpart remove_listener) either. Maybe @lucasfernog knows if he looked into that for the PR 🤷 If this is fixable this should really wait until the next major of course.
Thank you for your response. I believe this was an unintended change. Referring to the Tauri documentation custom listeners should align with the official naming conventions. Otherwise, it could introduce unnecessary cognitive overhead for future maintenance.
Describe the bug
When using addPluginListener, I found that registerListener is not allowed. Upon further investigation, I discovered that addPluginListener internally uses registerListener. I believe this does not conform to Rust's naming conventions, and it should be corrected to the previous register_listener.
Reproduction
tauri/packages/api/src/core.ts
Line 165 in f5a59b9
Expected behavior
use register_listener instead of registerListener.
Full
tauri info
outputStack trace
Additional context
I am not clear about the rationale behind this change. I would appreciate it if I could receive a response explaining the reasoning.
The text was updated successfully, but these errors were encountered: