From 81bf7a7f2c5298d5f67470329ca3c8b133437f7e Mon Sep 17 00:00:00 2001
From: Tom Carrio <tom@carrio.dev>
Date: Sat, 9 Nov 2024 23:02:43 -0500
Subject: [PATCH] feat: reference disks by id for deterministic evaluation of
 storage arrays

---
 nixos/server/blck0/disks.nix | 49 +++++++++++++++++++++++-------------
 1 file changed, 32 insertions(+), 17 deletions(-)

diff --git a/nixos/server/blck0/disks.nix b/nixos/server/blck0/disks.nix
index b2804c2..238f5e1 100644
--- a/nixos/server/blck0/disks.nix
+++ b/nixos/server/blck0/disks.nix
@@ -1,8 +1,23 @@
+# /dev/disk/by-id/ata-WDC_WD3200AAKS-00L9A0_WD-WCAV21751761 -> /dev/sda
+# /dev/disk/by-id/ata-Corsair_CMFSSD-256D1_131801888FF00002 -> /dev/sdb
+# /dev/disk/by-id/ata-WDC_WD10EFRX-68FYTN0_WD-WCC4J7TLCSNX -> /dev/sdc
+# /dev/disk/by-id/ata-WDC_WD10EFRX-68PJCN0_WD-WCC4J4XV4KDD -> /dev/sdd
+# /dev/disk/by-id/ata-WDC_WD10EFRX-68PJCN0_WD-WCC4J4XR859D -> /dev/sde
+# /dev/disk/by-id/ata-WDC_WD10EFRX-68FYTN0_WD-WCC4J2TJHS9P -> /dev/sdf
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R479906 -> /dev/sdh
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R479914 -> /dev/sdi
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R440706 -> /dev/sdj
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R471806 -> /dev/sdk
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R463915 -> /dev/sdl
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R458505 -> /dev/sdm
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R463905 -> /dev/sdn
+# /dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R451904 -> /dev/sdo
+
 _:
 let
   mkRaidDisk = name: dev: {
     type = "disk";
-    device = "/dev/${dev}";
+    device = dev;
     content = {
       type = "mdraid";
       inherit name;
@@ -16,7 +31,7 @@ in
     disk = {
       root = {
         type = "disk";
-        device = "/dev/sdj";
+        device = "/dev/disk/by-id/ata-Corsair_CMFSSD-256D1_131801888FF00002";
         content = {
           type = "gpt";
           partitions = {
@@ -46,21 +61,21 @@ in
         };
       };
 
-      ssd-a = mkSsdRaidDisk "sda";
-      ssd-b = mkSsdRaidDisk "sdb";
-      ssd-c = mkSsdRaidDisk "sdc";
-      ssd-d = mkSsdRaidDisk "sdd";
-      ssd-e = mkSsdRaidDisk "sde";
-      ssd-f = mkSsdRaidDisk "sdf";
-      ssd-g = mkSsdRaidDisk "sdg";
-      ssd-h = mkSsdRaidDisk "sdh";
 
-      # NOTE: /dev/sdi is the system OS
 
-      hdd-k = mkHddRaidDisk "sdk";
-      hdd-l = mkHddRaidDisk "sdl";
-      hdd-m = mkHddRaidDisk "sdm";
-      hdd-n = mkHddRaidDisk "sdn";
+      ssd-a = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R479906";
+      ssd-b = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R479914";
+      ssd-c = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R440706";
+      ssd-d = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R471806";
+      ssd-e = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R463915";
+      ssd-f = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R458505";
+      ssd-g = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R463905";
+      ssd-h = mkSsdRaidDisk "/dev/disk/by-id/ata-WDC_WDS120G2G0A-00JH30_19166R451904";
+
+      hdd-k = mkHddRaidDisk "/dev/disk/by-id/ata-WDC_WD10EFRX-68FYTN0_WD-WCC4J7TLCSNX";
+      hdd-l = mkHddRaidDisk "/dev/disk/by-id/ata-WDC_WD10EFRX-68PJCN0_WD-WCC4J4XV4KDD";
+      hdd-m = mkHddRaidDisk "/dev/disk/by-id/ata-WDC_WD10EFRX-68PJCN0_WD-WCC4J4XR859D";
+      hdd-n = mkHddRaidDisk "/dev/disk/by-id/ata-WDC_WD10EFRX-68FYTN0_WD-WCC4J2TJHS9P";
     };
 
     mdadm = {
@@ -76,7 +91,7 @@ in
               content = {
                 type = "filesystem";
                 format = "ext4";
-                mountpoint = "/storage/sdds";
+                mountpoint = "/storage/thorin";
               };
             };
           };
@@ -95,7 +110,7 @@ in
               content = {
                 type = "filesystem";
                 format = "ext4";
-                mountpoint = "/storage/hdds";
+                mountpoint = "/storage/beorn";
               };
             };
           };