Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Enhance Xcodegen architecture #11

Open
NicolasBuquet opened this issue Sep 2, 2024 · 0 comments
Open

[Build] Enhance Xcodegen architecture #11

NicolasBuquet opened this issue Sep 2, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request P3 Priority 3

Comments

@NicolasBuquet
Copy link
Collaborator

Actually, the structure uses 3 xcodegen files to generate the 3 TchapX targets:

  • TchapX-development : TchapX/development/SupportingFiles/target.yml
  • TchapX-staging : TchapX/staging/SupportingFiles/target.yml
  • TchapX-production : TchapX/staging/SupportingFiles/target.yml

The 3 target.yml files are identical except for some properties in base:settings:

    settings:
      base:
        PRODUCTION_APP_NAME: Tchap DEVELOPMENT
        BASE_APP_GROUP_IDENTIFIER: fr.gouv.tchapx.dev
        BASE_BUNDLE_IDENTIFIER: fr.gouv.tchapx.dev
        APP_NAME: TchapX-development
        APP_DISPLAY_NAME: TchapX-DEVELOPMENT
        ASSETCATALOG_COMPILER_APPICON_NAME: TchapX-icon

It should be better if these # files could be on unique template file accepting parameters:

Xcodegen is not made for templating.

It is possible to use envionment variables in xcodegen:

export TCHAPX_TARGET_BASEDIR="<my custom path>"
xcodegen generate --spec tchapx-project.yml

These will replace ${TCHAPX_TARGET_BASEDIR} string with the value provided.
This means 3 calls, one for each target, or 3 set of variables for each project.

I prefer exploring Genesis path.

@NicolasBuquet NicolasBuquet added P3 Priority 3 enhancement New feature or request labels Sep 2, 2024
@NicolasBuquet NicolasBuquet self-assigned this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 Priority 3
Projects
Status: No status
Development

No branches or pull requests

1 participant