Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing mod files #9

Open
hanjinliu opened this issue Mar 11, 2024 · 9 comments
Open

Support writing mod files #9

hanjinliu opened this issue Mar 11, 2024 · 9 comments

Comments

@hanjinliu
Copy link

Hi teamtomo members,
is there any plans to support writing a ImodModel into a mod file?
It'll be very nice if we can fully handle models on Python side.

@alisterburt
Copy link
Collaborator

Hey @hanjinliu ! Nice to see you here 😀

I don't have immediate plans to add this myself but would gladly accept a PR if someone else were to add support

@hanjinliu
Copy link
Author

Hi @alisterburt , hope you're doing well!

I'll send a PR if I could figure out how to do that, as I eagerly wanting this 😄

@alisterburt
Copy link
Collaborator

Nice! It should definitely be possible it just might be a little tedious going through the binary specification

Don't worry about the PR being finished before opening if you do open it up, happy to work on it a bit together :)

@MoritzWM
Copy link
Collaborator

I'll also gladly help you implementing this

@bbarad
Copy link

bbarad commented Jun 15, 2024

I am interested in this in order to routinely load my surface morphometrics meshes into imod, but I couldn't find any existing PR or progress on this - did I miss something? If not, I'll start with meshes (because of course thats the use case I need!) and open a PR and maybe we can expand from there before doing the full incorporation. Does that seem like a reasonable route forward?

@alisterburt
Copy link
Collaborator

I haven't seen any existing work yet but there's clear interest! If you want to jump on zoom this afternoon and work on it @bbarad id be down

@alisterburt
Copy link
Collaborator

Path forwards sounds reasonable

@bbarad
Copy link

bbarad commented Jun 15, 2024

I appreciate the offer but I gotta spend today on personal stuff before I travel again - maybe we can find a time later in the week once I am back at OHSU though!

@alisterburt
Copy link
Collaborator

Makes sense - I'm down but would have to be outside of work hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants