Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rating as float not just int #16

Open
baneizalfe opened this issue Mar 17, 2016 · 2 comments
Open

Set rating as float not just int #16

baneizalfe opened this issue Mar 17, 2016 · 2 comments

Comments

@baneizalfe
Copy link

Any plans making this feature?

@Den-Rimus
Copy link
Contributor

Sorry for being unresponsive for a long time.

How do you see showing the rating then? e.g. 3.5 rating would be shown as... what? 3 full stars and one filled for a half only?

@Den-Rimus
Copy link
Contributor

Currently there is no simple way to add this functionality. ProperRatingBar is a stupid horizontal LinearLayout that adds tick as many times as corresponding int field says.

There is an idea to process float instead of int by messing with the last tick's drawing - e.g. if rating is 3.75 - draw only rectangle with 75% width of the whole tick.

However, we do not need such element [so far] in our project where ProperRatingBar was implemented in the first place - and there is really not an ounce of a spare time to deal with this as a matter of supporting library. So - PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants