Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'root' node cannot use merge operation to create key #277

Open
lukaszachy opened this issue Jan 14, 2025 · 1 comment · May be fixed by #280
Open

'root' node cannot use merge operation to create key #277

lukaszachy opened this issue Jan 14, 2025 · 1 comment · May be fixed by #280
Assignees
@lukaszachy
Milestone
1.7

Comments

@lukaszachy
Copy link
Collaborator

lukaszachy commented Jan 14, 2025 •
edited
Loading

Originally posted by @lukaszachy in #276 (comment)

The problem is if this is the very top 'main.fmf':

env+:
  FOO: bar

If one creates a child node, eg. 'child.fmf':

env+:
   BAR: baz

one would expect to have:

/child:
  env:
    FOO: bar
    BAR: baz

as the result.

But instead it is

/child:
   env+:
      FOO: bar
   env:
     BAR: baz
@lukaszachy lukaszachy self-assigned this Jan 15, 2025
@lukaszachy
Copy link
Collaborator Author

Same behavior if /: inherit: false is used. But it is easy to fix.

@lukaszachy lukaszachy added this to the 1.6.1 milestone Jan 15, 2025
lukaszachy added a commit that referenced this issue Jan 15, 2025
@lukaszachy
Strip merge suffix in root node as well
d14292f 
Otherwise `key+` defined in root node or node with broken
inheritance will be called `key+` instead of `key`.
All other nodes already strip the merge suffix

Fix: #277
lukaszachy added a commit that referenced this issue Jan 15, 2025
@lukaszachy
Strip merge suffix in root node as well
c6e8a2c 
Otherwise `key+` defined in root node or node with broken
inheritance will be called `key+` instead of `key`.
All other nodes already strip the merge suffix

Fix: #277
@lukaszachy lukaszachy linked a pull request Jan 15, 2025 that will close this issue
Open
2 tasks
@lukaszachy lukaszachy modified the milestones: 1.6.1, 1.7 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaszachy lukaszachy

Labels
None yet
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

Strip merge suffix in root node as well teemtee/fmf
1 participant
@lukaszachy