Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently tektoncd/chains uses Deprecated in-toto/in-toto-golang Subject, StatementHeader, etc. structs. #1087

Closed
aaron-prindle opened this issue Mar 21, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Mar 21, 2024

Currently tektoncd/chains uses deprecated https://github.com/in-toto/in-toto-golang structs:

  • intoto.Subject{...}
  • intoto.StatementHeader{...}
  • intoto.ProvenanceStatementSLSA1{...}
  • intoto.StatementInTotoV01{...}

in-toto/in-toto-golang@3235174

https://github.com/in-toto/in-toto-golang/blob/master/in_toto/attestations.go#L32-L42

We should update tektoncd/chains code to use the correct structs

Possibly related: #920

@aaron-prindle aaron-prindle added the kind/bug Categorizes issue or PR as related to a bug. label Mar 21, 2024
@renzodavid9
Copy link
Contributor

With the work we did in #1111 and #1118, we migrated the structs to the non-deprecated versions. I think it should be fine to close this issue @chitrangpatel

@chitrangpatel
Copy link
Contributor

agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants