Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers (chains.tekton.dev) #1218

Open
jsoref opened this issue Sep 27, 2024 · 0 comments

Comments

@jsoref
Copy link

jsoref commented Sep 27, 2024

https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_chains/1148/pull-tekton-chains-integration-tests/1807738097719316480/

    {"level":"warn","ts":"2024-07-01T11:51:34.769Z","logger":"watcher","caller":"logging/warning_handler.go:32","msg":"API Warning: metadata.finalizers: \"chains.tekton.dev\": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers","commit":"2f98765-dirty"}

FinalizerName: "chains.tekton.dev",

The theoretical fix for this is:

- FinalizerName:     "chains.tekton.dev", 
+ FinalizerName:     "chains.tekton.dev/finalizer", 

But, in practice, if your objects are long lived, you will want to include migration code so that old finalizer values are accepted/handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant