GUI: Ctrl+Shift+ hotkeys not working with non-English keymap #4977
Comments
ghost
mentioned this issue
|
Hey there! This issue will be automatically closed in 7 days if there would be no activity. We therefore assume that the user has lost interest or resolved the problem on their own. Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue. Thanks! |
|
Still there, still annoying |
|
Hey there! This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own. Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue. Thanks! |
|
Still there, still annoying. The behavior changed a bit: now when pressing Ctrl+Shift+Z with RU keymap active, nothing happens (previously uppercase latin Z was typed). Less destructive since it doesn't overwrite undo/redo history, but still hotkey doesn't work as intended |
Maybe the "shortcuts-default.json" and "shortcuts-custom.json" could be parsed & mapped internally according to the "key position of M" in the EN layout, and not "M character key" itself? Also, I can't find the commands for changing the formatting shortcuts in "shortcuts-custom.json". I checked here. |
|
I'm mostly working on Linux code, but since no one looks into this and there's someone who doesn't allow stale-bot to close the issue, I tried to reproduce it and... I can't. vokoscreenNG-2021-10-03_08-02-28.mp4This is a VM with Russian Windows 10 1809 |
|
Windows 10 1803, I have that issue on the latest Telegram Beta
So all |
|
@grandsilence maybe it is a good reason to update to 1809? |
|
@ilya-fedin unfortunately 1803 is the last Windows version with low latency. It's a lot faster on old hardware. 1809 has 10MHz timer, absolutely no reasons to use 1809, 21h1 faster but slower than 1803. |
I don't think it's relevant, i'm on 21H2 and Ctrl-Shift hotkeys are not working with Russian layout on the latest Telegram Desktop |
|
@v0s what's relevant then? I can't reproduce the problem, Ctrl+Shift hotkeys work just fine on my machine with Russian layout |
|
@ilya-fedin How can I help in reproducing? I can think of making you a Windows VM in which the hotkeys don't work :-) |
|
@ilya-fedin I can make test environments on 1803, 1909, 2004, 21h1, 21h2 and provide VirtualBox image. Let me know if you need it. |
|
@v0s yeah, such a VM would be great. I have VirtualBox and libvirt. Although, I would need to make free space somehow apparently 😅 |
|
@ilya-fedin what's the best way to provide a functional instance without giving you access to my Telegram account? :-) E.g. is there a way to maybe register an account on test server, not tied to a phone number? 🤔 |
|
@ilya-fedin About 8Gb will be enough actually. 1803 is a tiny OS (especially without Metro Apps). |
|
@v0s I have an empty account and I can give access to it. Or just use any SMS activation service. |
|
@grandsilence yes please! you can pm me at t.me/mrvos |
|
@v0s you can remove |
|
I will download a new copy of tdesktop anyway most likely. So you can test with a portable copy and then remove it. |
well, i don't think we need to care about windows under 1909 (all of them unsuported) (and on 3 months under 20h2) |
|
This issue is now a part of #25126 |
|
Hey there! This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own. Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue. Thanks! |
|
Still there, still annoying |
|
I hope this problem will be fixed someday… |
|
|
any news? |
|
Telegram Desktop 4.10.2 (Windows 10) has somewhat related problem:
Update: Telegram Desktop 4.11.1 still has the issue with |
|
We are here... |
|
|
|
Yeah, Telegram Desktop: v4.15.2 x64 Working keystrokes for both keyboard layouts:
Not working keystrokes on RU keyboard layout, EN works as expected:
|
|
Every keystroke aside from |
|
Still here |
|
Still here. Ubuntu LTS 20.04, TG Desktop 4.16.8. |
Well, I mentioned I added this issue to #25126 which means it needs help with reporting upstream. If someone would make a Qt bugreport complying with Qt's reporting rules, that would likely move the issue forward way faster. |
|
@john-preston @ilya-fedin fixed partially: markdown hotkeys now work with the custom keymap, but e.g. Ctrl-Shift-Z for redo does not (thanks for figuring it out and fixing as well!) |
|
While those shortcuts were partially under tdesktop control and it was possible to switch them from one Qt API to the other, Ctrl+Shift+Z is completely implemented by Qt, here: https://github.com/qt/qtbase/blob/v5.15.14-lts-lgpl/src/widgets/widgets/qwidgettextcontrol.cpp#L1326 So I don't see a way to fix it. The already made fix is considered for revert, though, because it broke those shortcuts on macOS completely. |
|
Ooh i see...
Can it be perhaps put into a block conditional on target OS? Currently it does solve a problem on Windows |
Not sure. Will see. |
|
If you can reproduce the redo thing with other Qt applications like qBittorrent, I guess you should be able to report this to Qt? qBittorrent will also show whether this is still an issue with modern Qt (tdesktop still uses 5.15 on Windows while qBittorrent has Qt 6 builds) or is already fixed. I would recommend reporting it as an issue with standard layouts such as the ukranian enhanced one, rather than a custom one. |
|
Yep, it does reproduce on beta qBittorrent as well. I know nothing about Qt APIs though to be able to correctly submit a bug report to Qt :( |
|
I'm sorry but no one else seem to be interested in reporting and if you won't do that, the bug will remain unfixed for another decade. Just report as you can. Mention that the issue happens with both tdesktop and qbittorrent, provide reproduction steps. Specify the Qt versions used by tdesktop and qbittorrent (the tdesktop one is 5.15.13). The components are QPA: Windows and GUI: Basic input system. You can mention that it's likely reproducible with any Qt example using QTextEdit/QLineEdit. |
|
I believe that this recent change has broken markdown shortcuts for all layouts on my machine. Were working perfectly fine before. |
|
@kekekeks Can you share some details? One version completely broke markdown shortcuts on macOS and on Linux systems with global menu, but after that there was deployed a fix version. Maybe you need to update in Settings > Advanced > Check for updates? |
Steps to reproduce
Same applies to Ctrl+Shift+M hotkey for monospace formatting.
Expected behaviour
Even with RU keymap, Ctrl+Shift+Z should redo, and Ctrl+Shift+M should make text monospace.
Actual behaviour
With RU keymap, Ctrl+Shift+ hotkeys do not do the actions, instead they type corresponding capital English letter.
Configuration
Operating system: Windows 10 1709
Version of Telegram Desktop: 1.3.10
Used theme: default
The text was updated successfully, but these errors were encountered: