Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values of metric variables cannot be changed using the same metric unit as the default one #135

Open
2 tasks
petar-i-todorov opened this issue Dec 13, 2024 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@petar-i-todorov
Copy link

petar-i-todorov commented Dec 13, 2024

Describe the bug
Some variables, like kendo-grid-padding-y and kendo-grid-padding-x, are assigned default values, such as kendo-spacing-2. The value of kendo-spacing-2 uses the rem measurement unit. However, if you change the value of kendo-grid-padding-y to a hard-coded value or to another variable that uses the same metric unit, the validation fails.

To Reproduce
Steps to reproduce the behavior:

  1. Open a new Kendo Default project.
  2. Open the Grid component.
  3. Enable the component-specific variables.
  4. Set the value of kendo-grid-padding-y to 1rem.

Actual Results
The validation fails, even though the kendo-grid-padding-y variable refers to the variable kendo-spacing-2 (rem-based) by default.

Expected behavior
The validation doesn't fail.

Screenshots
Image
Image

Image

Related Items
https://feedback.telerik.com/themebuilder/1655237-allow-rem-values-in-all-metric-variables

Reported through t.1673350.

  • Issue 1: The Issue from the comment is still reproducible
  • Issue 2: The original issue is reproducible if there is more than one level of referance
@petar-i-todorov petar-i-todorov added the Bug Something isn't working label Dec 13, 2024
@petar-i-todorov petar-i-todorov self-assigned this Dec 17, 2024
@NickIliev
Copy link
Member

+1 from t.1674488

Reproducible with the default values in brand-new Material project.

Repro steps:

  1. Create a new project with the Material theme
  2. Observe the default value for $kendo-spacing-4b (it's 1rem)
  3. Set $kendo-spacing-4 to 8px
  4. Try set $kendo-spacing-4 to 1rem

Result: the validation fails and prevents from reverting to REM units.

@Martin-Hristov
Copy link

Issue 1: The Issue from the comment is still reproducible

#135 (comment)

@Martin-Hristov
Copy link

Issue 2: The original issue is reproducible if there is more than one level of referance

  1. Open Kendo Default project
  2. Open the Grid
  3. Check that $kendo-grid-cell-padding-x is equal to $kendo-grid-padding-x which equal $kendo-spacing-2 = 1rem
  4. Try to set $kendo-grid-cell-padding-x to 2rem

Actual: the validation fails and the original value is restored. If the user first sets $kendo-grid-padding-x to 1rem, than $kendo-grid-cell-padding-x can also be set to rem values

Expected: All variables that can be traced to rem values can accept them

@NickIliev
Copy link
Member

NickIliev commented Jan 30, 2025

+1 from t.1677308 (Kendo Default theme - changing the kendo-border-radius variable to any other radii-generated variables that uses REM)

The client hits "the value is invalid. The supported units are: px, pt" when trying to change the kendo-border-radius-lg to $kendo-border-raduis-md and vice verse.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants