Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Multiple hosts for postgres12_pgx #634

Open
vovcyan opened this issue Jan 26, 2025 · 1 comment
Open

[Feature Request] Multiple hosts for postgres12_pgx #634

vovcyan opened this issue Jan 26, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@vovcyan
Copy link

vovcyan commented Jan 26, 2025

Describe the solution you'd like

postgres12_pgx plugin can work with multiple PostgreSQL hosts but in helm chart there is an option to pass only 1 host. Because of dynamic changes in random moment of master/replica roles of hosts in Postgres cluster (or due maintenance) there is no option specify only master host in config.

Current solution server-configmap.yaml#L35 supports only 1 host for SQL persistence and visibility:

connectAddr: "{{ include "temporal.persistence.sql.host" (list $ "default") }}:{{ include "temporal.persistence.sql.port" (list $ "default") }}"

Example of passing multiple hosts for postgres12_pgx

...
pluginName: "postgres12_pgx"
databaseName: "main"
connectAddr: "a-host.com:5432,b-host.com:5432,c-host.com:5432"
connectProtocol: "tcp"
...

Additional context

I can help with PR

@vovcyan vovcyan added the enhancement New feature or request label Jan 26, 2025
@vovcyan
Copy link
Author

vovcyan commented Jan 26, 2025

@robholland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant