Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateHandle should have a getResult method #2212

Open
drewhoskins-temporal opened this issue Sep 12, 2024 · 0 comments · May be fixed by #2324
Open

UpdateHandle should have a getResult method #2212

drewhoskins-temporal opened this issue Sep 12, 2024 · 0 comments · May be fixed by #2324
Labels
enhancement User experience

Comments

@drewhoskins-temporal
Copy link

drewhoskins-temporal commented Sep 12, 2024

Is your feature request related to a problem? Please describe.

Usability nit. To get the result of the update, you have to do
handle.getResultAsync().get()
Given that updates are mostly used for synchronous use cases, could we make this more convenient?

Describe the solution you'd like
It makes sense to have a getResult() convenience helper that aliases the above code.

Describe alternatives you've considered

We considered renaming the async version to getResult() to be consistent with some other methods on the Java SDK.
But we decided that WorkflowStub has getResult/getResultAsync which is precedent enough given there's no way to be globally consistent.
And that having both is clearer and more usable.

Additional context
Add any other context or screenshots about the feature request here.

@drewhoskins-temporal drewhoskins-temporal added the enhancement User experience label Sep 12, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement User experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant