Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task and source to build_module_name func #1096

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add task and source to build_module_name func #1096

merged 1 commit into from
Jan 27, 2025

Conversation

ashokkumarkannan1
Copy link
Contributor

Fix: #1095

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran437 passed228 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests823 ran492 passed331 skipped0 failed
TestResult
No test annotations available

nvukobratTT
nvukobratTT reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm assigning few more reviewers for check as this PR is a bit bigger

forge/test/models/utils.py Outdated Show resolved Hide resolved
@ashokkumarkannan1
Copy link
Contributor Author

Hi @nvukobratTT , @mstojkovicTT , @vkovinicTT
I have updated the requested changes and this PR is now ready for review.

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests551 ran475 passed76 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests493 ran425 passed68 skipped0 failed
TestResult
No test annotations available

@ashokkumarkannan1 ashokkumarkannan1 merged commit 8573421 into main Jan 27, 2025
6 checks passed
@ashokkumarkannan1 ashokkumarkannan1 deleted the akannan/task_source branch January 27, 2025 10:54
@ashokkumarkannan1
Copy link
Contributor Author

Thanks for Approving @nvukobratTT @mstojkovicTT @vkovinicTT :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkovinicTT vkovinicTT vkovinicTT approved these changes

@mstojkovicTT mstojkovicTT mstojkovicTT approved these changes

@nvukobratTT nvukobratTT nvukobratTT approved these changes

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@dgolubovicTT dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Task and Source details in module_name construction
4 participants
@ashokkumarkannan1 @nvukobratTT @mstojkovicTT @vkovinicTT