You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
See #15889 for context.
Previously, our handling of mantissa rounding is always round to nearest. If tied, round up. This is incorrect and in this PR #16997, I will correct it to round to even on ties.
However, after the change, I noticed ttnn.typecast op doesn't give exact match for host conversion vs. device conversion. These 3 tests in tests/ttnn/unit_tests/operations/eltwise/test_eltwise_typecast.py break:
Just confirmed with the HW team that WH and BH both DO NOT support rounding to even, only rounding up in case of ties. This means that the original implementation was accurately modelling HW.
Describe the bug
See #15889 for context.
Previously, our handling of mantissa rounding is always round to nearest. If tied, round up. This is incorrect and in this PR #16997, I will correct it to round to even on ties.
However, after the change, I noticed
ttnn.typecast
op doesn't give exact match for host conversion vs. device conversion. These 3 tests intests/ttnn/unit_tests/operations/eltwise/test_eltwise_typecast.py
break:To Reproduce
Steps to reproduce the behavior:
Expected behavior
The tests should fail without those changes and pass with them if hardware does the same rounding spec (ie. round to even).
The text was updated successfully, but these errors were encountered: