Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor Comparison API #222

Open
GregHattJr opened this issue Nov 7, 2024 · 0 comments
Open

Tensor Comparison API #222

GregHattJr opened this issue Nov 7, 2024 · 0 comments

Comments

@GregHattJr
Copy link
Contributor

GregHattJr commented Nov 7, 2024

Description

Currently API reading of the Tensors is blocked by the inability to read tensor (.pt) files on a non-host machine. Once this issue is resolved we will have the ability to read the tensor files from a given report. The UI will allow users to check the tensors of a given operation against the golden tensor (if the comparison exists).

New API Endpoints

Tensor Comparison
api/compare-tensor/local/<tensor-id>
api/compare-tensor/global/<tensor-id>

These endpoints will check the global_tensor_comparison_records and local_tensor_comparison_records and return the diff if the comparison files exist.

Changes to Existing API

Operation Details

Each Input/Output will have a comparisons node with an optional local and global which are TensorComparisonRecords

{
  "comparisons": {
    "local": {
      "tensor_id": 1,
      "golden_tensor_id": 5,
      "matches": false,
      "desired_pcc": 0.123,
      "actual_pcc": 1.23
    },
    "global": {
      "tensor_id": 2,
      "golden_tensor_id": 5,
      "matches": true,
      "desired_pcc": 0.1233,
      "actual_pcc": 1.1233
    }
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant