Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid events emission drilling #407

Open
wazolab opened this issue Oct 28, 2024 · 0 comments
Open

Avoid events emission drilling #407

wazolab opened this issue Oct 28, 2024 · 0 comments
Assignees
Milestone

Comments

@wazolab
Copy link
Member

wazolab commented Oct 28, 2024

The aim of this issue is to remove the cascading event emission between PoiCardContent and all his parent components.
We could simply trigger an action from PoiCardContent when catching a user event.
Then we could base High-level components / pages on state from the store for further behaviors.

Applies to:

  • zoomClick
    • Check if selectedFeature is set, if not set the clicked one (pass an action=zoom arg to setSelectedFeature action)
    • From pages, on selectedFeature watch with action === zoom, call mapFeature.goToSelectedFeature() method
  • exploreClick
  • favoriteClick
@wazolab wazolab added this to the v1.24 milestone Oct 28, 2024
@wazolab wazolab self-assigned this Oct 28, 2024
@wazolab wazolab modified the milestones: v1.24, v1.25 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant