Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added prefix validation #329

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: added prefix validation #329

wants to merge 10 commits into from

Conversation

kierramarie
Copy link
Contributor

@kierramarie kierramarie commented Nov 15, 2024

Description

Added validation to check for proper prefix. The COS module has limit on the prefix, so each module that uses the COS module needs to adapt to this limit.

Git Issue: terraform-ibm-modules/terraform-ibm-cos#770

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Contributor Author

/run pipeline

alex-reiff
alex-reiff previously approved these changes Nov 20, 2024
@kierramarie
Copy link
Contributor Author

/run pipeline

@kierramarie
Copy link
Contributor Author

/run pipeline

@kierramarie
Copy link
Contributor Author

/run pipeline

@kierramarie
Copy link
Contributor Author

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jan 20, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jan 20, 2025

@kierramarie, can you please link the related github issue in the PR template and other missing info.

@Ak-sky
Copy link
Member

Ak-sky commented Jan 20, 2025

CRA scan failed with below error

Plan: 1 to add, 0 to change, 0 to destroy.
╷
│ Error: Invalid function argument
│ 
│   on variables.tf line 53, in variable "prefix":
│   53:         length(regexall("^.*--.*", var.prefix)) == 0
│     ├────────────────
│     │ while calling regexall(pattern, string)
│     │ var.prefix is null
│ 
│ Invalid value for "string" parameter: argument must not be null.
╵

Error: Process completed with exit code 1.

@kierramarie
Copy link
Contributor Author

/run pipeline

@kierramarie
Copy link
Contributor Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants