Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified text for admin password #121

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix: modified text for admin password #121

merged 4 commits into from
Dec 5, 2023

Conversation

imprateeksh
Copy link
Member

Description

Refer Issue-6615

Fixed the below:

  • Remove text mentioning range of admin password
  • Modified the pr_tests to include passwords for administrator as greater than or equal to 15 characters.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@imprateeksh imprateeksh self-assigned this Nov 26, 2023
@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh
Copy link
Member

ocofaigh commented Dec 5, 2023

/run pipeline

@ocofaigh ocofaigh merged commit 967d76e into main Dec 5, 2023
@ocofaigh ocofaigh deleted the 6615-pwd-length branch December 5, 2023 10:24
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants