Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ExistingResourceInstances test #248

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: update ExistingResourceInstances test #248

merged 2 commits into from
Jan 29, 2025

Conversation

aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Jan 27, 2025

Description

The ExistingResourcesInstances has been updated so that it can check the case where users give cloud_monitoring_crn as input.

Resolves: #247

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

The ExistingResourcesInstances has been updated so that it can check the case where users give cloud_monitoring_crn as input, preventing the validation failure for release v2.6.2.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 changed the title feat: update ExistingResourceInstances test fix: update ExistingResourceInstances test Jan 27, 2025
@aatreyee2506
Copy link
Contributor Author

/run pipeline

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aashiq-J Aashiq-J merged commit 89da484 into main Jan 29, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the issue_12348 branch January 29, 2025 04:23
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the existing resource test to check for case when cloud_monitoring_crn is inputted by user
4 participants