You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There was a test not using AsynchronousDeferredRunTest but using the main reactor and it left the reactor dirty...
Then, another test was executed with AsynchronousDeferredRunTest and the main reactor. This test was fine, but test were still failing as it was now detecting that reactor is not clean.
I think that in twistedsuppor there should be a dedicated TestCase to check for junk at tearDown for the main reactor
Also, I think that besides delayedcalls, readers and writers and threads should also be considered junk
For my projects I am using a simplified TwistedTestCase on top of stdlib TestCase and here is the reactor cleanup check that I use:
This is an issue I found in txacme..
There was a test not using AsynchronousDeferredRunTest but using the main reactor and it left the reactor dirty...
Then, another test was executed with AsynchronousDeferredRunTest and the main reactor. This test was fine, but test were still failing as it was now detecting that reactor is not clean.
I think that in twistedsuppor there should be a dedicated TestCase to check for junk at tearDown for the main reactor
Also, I think that besides delayedcalls, readers and writers and threads should also be considered junk
For my projects I am using a simplified TwistedTestCase on top of stdlib TestCase and here is the reactor cleanup check that I use:
https://github.com/chevah/compat/blob/master/chevah/compat/testing/testcase.py#L310
The text was updated successfully, but these errors were encountered: