Does the v5 branch include the changes from the last commit in 2022? #96
Replies: 5 comments
-
|
Never mind. It won't do it on the site, but it loaded the history in GitHub Desktop. Those changes are there. |
Beta Was this translation helpful? Give feedback.
-
|
UPDATE After restarting Firefox, the history for the branch loaded properly online. (My mistake.) Anyway, now I run into this issue:
I can't figure out how to install NVM in Windows directly, so I've started all over using WSL. I should be able use NVM change node's version in order to make it build, I hope. Should I completely avoid the main branch for now, since it says the following?
|
Beta Was this translation helpful? Give feedback.
-
|
These are the steps I just took to fail to build the editor from the v5 branch using WSL 🙃: sudo apt update
sudo apt install nodejs npm
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bashAt this point, I close WSL then reopen it. You can probably enter a command to restart the shell, but I don't feel like looking that up right now. nvm install 11.15.0
nvm use 11.15.0Now we can follow the provided instructions: npm install bower -g
npm install gulp-cli -gThis is the way I clone the repo: cd ~/Documents/GitHub
git clone https://github.com/textadventures/squiffy.git
cd squiffy
git switch v5
cd editorNow back to the provided instructions: npm install
bower install
gulp windows❗ { Error: spawn wine ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:247:19)
at onErrorNT (internal/child_process.js:429:16)
at processTicksAndRejections (internal/process/task_queues.js:81:17)
errno: 'ENOENT',
code: 'ENOENT',
syscall: 'spawn wine',
path: 'wine',So lessons learned... Don't attempt this from WSL. 😜 Or from PowerShell. 🙃 🤔 Well... I do already have WINE installed on Linux... Man, I really hate to do this, but I'm going to have to log out of Windows 10 and try this on Linux. (Yes: I am being a smart alec. My laptop and I prefer Linux, hands down.) Will KV eventually build the Squiffy Desktop Editor for Windows? |
Beta Was this translation helpful? Give feedback.
-
|
On Linux, this prints during the build: > [email protected] install /home/kv/Documents/GitHub/squiffy/editor/dist/node_modules/fs-xattr > node-gyp rebuild gyp ERR! configure error gyp ERR! stack Error: Command failed: /usr/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3]; gyp ERR! stack File "<string>", line 1 gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3]; gyp ERR! stack ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ gyp ERR! stack SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)? gyp ERR! stack gyp ERR! stack at ChildProcess.exithandler (child_process.js:294:12) gyp ERR! stack at ChildProcess.emit (events.js:182:13) gyp ERR! stack at maybeClose (internal/child_process.js:978:16) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5) gyp ERR! System Linux 6.6.47-1-lts gyp ERR! command "/home/kv/.nvm/versions/node/v11.2.0/bin/node" "/home/kv/.nvm/versions/node/v11.2.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" gyp ERR! cwd /home/kv/Documents/GitHub/squiffy/editor/dist/node_modules/fs-xattr gyp ERR! node -v v11.2.0 gyp ERR! node-gyp -v v3.8.0 gyp ERR! not ok ...but it doesn't say the build failed. In fact, it seems to have built. So, switching back to Windows now to test it... Note As mentioned here, I did have to copy the jQuery directory to the proper place after the build. |
Beta Was this translation helpful? Give feedback.
-
|
Success! The Windows build from Linux works in Windows 10. |
Beta Was this translation helpful? Give feedback.
-
Does the v5 branch include those changes from that last commit in 2022? Or is it the same thing as the latest release?
It won't load the history for that branch for some reason.
Beta Was this translation helpful? Give feedback.
All reactions