From 3280c3030aae46d94f2d486d088ccbf5ee714606 Mon Sep 17 00:00:00 2001 From: Peter Kaminski Date: Sat, 9 Nov 2024 07:32:31 -0800 Subject: [PATCH 1/2] (documentation change) Specify full path to /usr/bin/xattr for macOS, fixes #2583 On some Macs, Homebrew installs its own `xattr` which doesn't have the `-r` option. See #2583. This PR just adds the full path to the system `xattr` in `README.md`, so the `-r` in the instructions doesn't cause a problem. It's not clear to me whether or not the `-r` is required; this PR does not address that question, it just routes around it. I have tested the instruction on my Mac which has the Homebrew `xattr`, and with the added path, it works. I would assume this change is low risk; it's just to documentation, and the change points to a system command that should always be there. However, it's possible I'm missing corner cases that further testing and validation on more machines would uncover. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5925641917..c56fa09642 100644 --- a/README.md +++ b/README.md @@ -192,7 +192,7 @@ brew install th-ch/youtube-music/youtube-music If you install the app manually and get an error "is damaged and can’t be opened." when launching the app, run the following in the Terminal: ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows From 182fbcf372a2d73b7a2d05d079058b85df266d46 Mon Sep 17 00:00:00 2001 From: Peter Kaminski Date: Sat, 9 Nov 2024 17:13:58 -0800 Subject: [PATCH 2/2] Also update es, fr, is, ko, ru READMEs Changed `xattr` instruction to `/usr/bin/xattr` in non-en README.md files. Fix for #2583. Done by recursive grep, so this should be all of them. Command line used: ```shell perl -p -i -e 's/^xattr/\/usr\/bin\/xattr/' `egrep -rl xattr .` ``` --- docs/readme/README-es.md | 2 +- docs/readme/README-fr.md | 2 +- docs/readme/README-is.md | 2 +- docs/readme/README-ko.md | 2 +- docs/readme/README-ru.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/readme/README-es.md b/docs/readme/README-es.md index 66d3518301..3dfc455734 100644 --- a/docs/readme/README-es.md +++ b/docs/readme/README-es.md @@ -182,7 +182,7 @@ brew install th-ch/youtube-music/youtube-music Si instalas la aplicación manualmente y obtienes un error "está dañado y no se puede abrir" al iniciar la aplicación, ejecuta lo siguiente en la Terminal: ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows diff --git a/docs/readme/README-fr.md b/docs/readme/README-fr.md index c65c236ec2..2e626436e8 100644 --- a/docs/readme/README-fr.md +++ b/docs/readme/README-fr.md @@ -185,7 +185,7 @@ brew install th-ch/youtube-music/youtube-music Si vous installez l'application manuellement et obtenez une erreur "est endommagé et ne peut pas être ouvert." lors du lancement de l'application, exécutez ce qui suit dans le Terminal : ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows diff --git a/docs/readme/README-is.md b/docs/readme/README-is.md index 291ad60a9f..903002828f 100644 --- a/docs/readme/README-is.md +++ b/docs/readme/README-is.md @@ -180,7 +180,7 @@ brew install th-ch/youtube-music/youtube-music Ef þú setur upp forritið handvirkt og færð villu "er skemmd og ekki er hægt að opna það," þegar þú ræsir forritið skaltu keyra eftirfarandi í flugstöðinni: ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows diff --git a/docs/readme/README-ko.md b/docs/readme/README-ko.md index aaef632d0f..4c37bb88c3 100644 --- a/docs/readme/README-ko.md +++ b/docs/readme/README-ko.md @@ -147,7 +147,7 @@ brew install --cask https://raw.githubusercontent.com/th-ch/youtube-music/master (앱을 수동으로 설치하고) 앱을 실행할 때 `손상되었기 때문에 열 수 없습니다.`라는 오류가 발생하면 터미널에서 다음을 실행하세요: ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows diff --git a/docs/readme/README-ru.md b/docs/readme/README-ru.md index 2d9b635c1a..85b1f262e5 100644 --- a/docs/readme/README-ru.md +++ b/docs/readme/README-ru.md @@ -168,7 +168,7 @@ brew install th-ch/youtube-music/youtube-music Если вы устанавливаете приложение вручную и получаете ошибку "is damaged and can’t be opened.", запустите в терминале следующую команду: ```bash -xattr -cr /Applications/YouTube\ Music.app +/usr/bin/xattr -cr /Applications/YouTube\ Music.app ``` ### Windows