Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated to th2 gradle plugin and Kotlin DSL #18

Merged
merged 12 commits into from
Mar 20, 2024
Merged

Migrated to th2 gradle plugin and Kotlin DSL #18

merged 12 commits into from
Mar 20, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

OptimumCode
OptimumCode requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@OptimumCode OptimumCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but probably we should check setup.py if it requires since the location of proto files has been changed

@Nikita-Smirnov-Exactpro
Copy link
Member Author

I am not sure but probably we should check setup.py if it requires since the location of proto files has been changed

setup.py looks at the 'build/generated/source/proto/main/services/python' folder where gradle puts generated code. I didn't find references to the source proto file

@Nikita-Smirnov-Exactpro
Copy link
Member Author

Hm ... I don't understand why full build isn't triggered

@OptimumCode
Copy link
Member

Hm ... I don't understand why full build isn't triggered

Because there is an error in workflow

Invalid workflow file: .github/workflows/dev-build.yml#L35
The workflow is not valid. .github/workflows/dev-build.yml (Line: 35, Col: 20): Invalid secret, nvd-api-key is not defined in the referenced workflow.

OptimumCode
OptimumCode reviewed Mar 20, 2024
View reviewed changes
@OptimumCode
Copy link
Member

Seems like the python build uses proto src after all
error: cannot copy tree 'proto/th2_grpc_read_db': not a directory

@OptimumCode
Copy link
Member

OptimumCode commented Mar 20, 2024 •
edited
Loading

It happens here and here.

OptimumCode
OptimumCode reviewed Mar 20, 2024
View reviewed changes
OptimumCode
OptimumCode approved these changes Mar 20, 2024
View reviewed changes
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro changed the base branch from TH2-5177 to dev-2 March 20, 2024 11:10
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit 0f64ba7 into dev-2 Mar 20, 2024
10 of 11 checks passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro deleted the migrate-to-plugin branch March 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OptimumCode OptimumCode OptimumCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nikita-Smirnov-Exactpro @OptimumCode