Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP: HttpRequester Inheritance from AdapterBase does not make sense #88

Open
Mostafa-Armandi opened this issue Nov 13, 2020 · 0 comments
Open

OCP: HttpRequester Inheritance from AdapterBase does not make sense #88

Mostafa-Armandi opened this issue Nov 13, 2020 · 0 comments

Comments

@Mostafa-Armandi
Copy link

In Open-Closed principle section and in the "Bad" code sample, Inheriting from AdapterBase by HttpRequester make no sense and is misleading. It is a typo in my understanding.
class HttpRequester : AdapterBase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mostafa-Armandi