-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free groupoids and final functors #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's dying but it's not dead yet.
Eliminate some duplication by specialising the universal property of the free groupoid to congruences.
plt-amy
reviewed
Jan 26, 2024
plt-amy
previously approved these changes
Jan 30, 2024
ncfavier
commented
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much, much better than what I came up with!
plt-amy
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #335 in the maximally annoying way, by using the fully correct definition of final functors:
The new definition is much more annoying to work with and I am very much open to improvements to the proofs, particularly the closure under composition of final functors. I couldn't find the argument fully spelt out anywhere (even the nlab handwaves that it "suffices to consider the case of a zigzag of length one"), and I think I understand why...
Checklist
Before submitting a merge request, please check the items below:
support/sort-imports.hs
(ornix run --experimental-features nix-command -f . sort-imports
).If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with
chore:
.