Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

repo: cleanup and remove unnecessary images #402

Open
vince-fugnitto opened this issue Sep 8, 2020 · 4 comments
Open

repo: cleanup and remove unnecessary images #402

vince-fugnitto opened this issue Sep 8, 2020 · 4 comments
Labels

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Sep 8, 2020

Description

The framework has moved towards using vscode extensions to provide language and debugging features, and consequently it should be possible to remove unnecessary images which only differ in the vscode extensions they include.

Motivation

  1. less maintenance overall (fewer images to maintain and manage).
  2. theia-full already covers most languages (no need for individual images for a specific language).
  3. the difference between images is minimal (main difference is vscode extensions included).
  4. the images are used for reference and are not official, those who wish to create their own images can be inspired by them and they are present in the history of the repository.

Potentially Remove:

  • theia-rust
  • theia-dart
  • theia-swift
  • theia-ruby
  • theia-python
  • theia-go

cc @theia-ide/core

@marcdumais-work
Copy link
Member

the difference between images is minimal (main difference is vscode extensions included).

I would rather say that the difference between the various Theia applications, made available in our variuos images, is minimal. So we can consider keeping some images if they bring something "special" vs theia-full, even if their Theia app is not special. e.g. theia-rust is different enough that it may be worthwhile to keep it.

@vince-fugnitto
Copy link
Member Author

I wanted to try and discuss what we should try to keep and what can be removed, are there images that we are particularly interested in maintaining besides theia-docker and theia-full-docker.

@vince-fugnitto
Copy link
Member Author

The theia-java should be removed, it requires a lot of changes and currently uses an old deprecated base java8 image. In addition, the theia-full image already makes use of java (11) so there is no need for the individual image.

@stale
Copy link

stale bot commented Nov 11, 2020

This contribution has been automatically marked as stale due to inactivity, and it will be closed if no further activity occurs. Thank you for contributing to Theia!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants