Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all sorts of invalid input unittests via POST /api/v1/signed-change-requests/ #458

Open
dmugtasimov opened this issue Oct 19, 2021 · 0 comments

Comments

@dmugtasimov
Copy link
Contributor

dmugtasimov commented Oct 19, 2021

DEPENDS ON:

TODO:

  • Use pytest parametrizartion
  • For each role: regular node, CV, PV
  • Regular node must not let invalid signed change requests to PV to reduce load and also for user experience (fail fast), but it should not do validations that require up to date blockchain
  • Checks including, but not limited to: invalid format, types, business logic inconsistencies
  • Improve code implementation as needed to pass the tests
  • Fix typos in endpoint name. Add missed "s" to the end
@dmugtasimov dmugtasimov changed the title Implement all sorts on invalid input unittests via POST /api/v1/signed-change-requests/ Implement all sorts of invalid input unittests via POST /api/v1/signed-change-requests/ Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants