Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create blockchain management command #463

Open
dmugtasimov opened this issue Oct 26, 2021 · 4 comments · Fixed by #480
Open

Create blockchain management command #463

dmugtasimov opened this issue Oct 26, 2021 · 4 comments · Fixed by #480

Comments

@dmugtasimov
Copy link
Contributor

dmugtasimov commented Oct 26, 2021

TODO:

  • Command name blockchain
  • Subcommands get-block (print block JSON by block number), get-blocks (print range of block JSONs by block numbers), get-blockchain-state (print by block number) (use subparsers)
  • Allow --api <network-address> option (use APIBlockchain in that case) -> submit in the second PR, so we can get locally operating management command earlier
  • Use def yield_blocks_slice(self, from_block_number: int, to_block_number: int): for both get-block and get-blocks in API mode to save development time (put corresponding TODO to refactor it later)
@olegtropinin
Copy link
Contributor

@dmugtasimov
Could you assign this task to me again after merging of existed PR. I have to implement getting of blocks, range of blocks, blockchain state from API blockchain interface.

@dmugtasimov
Copy link
Contributor Author

@olegtropinin thank you, merged. I may add some improvements now

@dmugtasimov dmugtasimov reopened this Oct 30, 2021
@dmugtasimov
Copy link
Contributor Author

@olegtropinin I decided to rename the command

@dmugtasimov
Copy link
Contributor Author

@olegtropinin made many changes. let's discuss them tomorrow: #482

I looks like only implementation of get-blockchain-state for remote blockchain is left to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants