Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipelining/join.h:65: 'prepare' marked 'override' but does not override any member functions #167

Open
freekvw opened this issue Nov 3, 2014 · 2 comments
Open

pipelining/join.h:65: 'prepare' marked 'override' but does not override any member functions #167

freekvw opened this issue Nov 3, 2014 · 2 comments

Comments

@freekvw
Copy link
Collaborator

freekvw commented Nov 3, 2014

See title.
@Mortal
Copy link
Collaborator

Mortal commented Nov 3, 2014

Hm... The code doesn't seem to be wrong. source_impl<dest_t> derives from source_base which derives from node. Maybe the override keyword is only applicable when the method is in a direct base class?

@SSoelvsten
Copy link
Contributor

Since join_test is part of test_pipelining.cpp and that one has no compiler warnings regarding this, I would assume this can be closed due to updates in the C++ compilers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mortal @freekvw @SSoelvsten