Issue #196 : Pipelining duplication lambda_t
and map_t
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196 .
Proposed Changes
lambda
in favour ofmap
(with deprecation warnings)exclude_lambda
in favour of a newfilter_map
(with deprecation warnings). This is such that a more consistent naming scheme is provided.std::pair<T,bool>
is used. Is it of interest to also support astd::optional<T>
introduced in C++17? Based on this StackOverflow a pair is in terms of performance faster if the element constructor is cheap..first
and.second
the wrong way around compared to its implementation.Possible Changes (but I cannot tell whether these are desired)
map
, i.e.map_temp
,map_sink
andpush_map
. Should the same also be made for pipelining/filter.h and pipelining/filter_map.h?