Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't calculate the accurip checksums if the disc isn't in the accurip DB #125

Open
AdamWill opened this issue May 12, 2015 · 3 comments

Comments

@AdamWill
Copy link

From the console output, it looks like morituri checks whether the album is in the accurip DB before calculating the checksums - but even when it isn't, goes ahead and calculates them anyway. What's the point? It's just a waste of time. It already knows it has nothing to compare them to.

This is with latest git master.

@thomasvs
Copy link
Owner

The checksums go into the log. The accurip checksums may land in the db at a later date, at which time the logs can then be compared to the db. Presumably that is why EAC puts them in the logs as well, and why they are required by certain sites.

@ArchangeGabriel
Copy link

@thomasvs: Yes, exactly.

@baldurmen
Copy link

This does not look like a bug and should thus be closed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants