Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not get fee by txHash with cosmos-sdk #62

Open
Wangmmx opened this issue Jul 19, 2023 · 2 comments
Open

Can not get fee by txHash with cosmos-sdk #62

Wangmmx opened this issue Jul 19, 2023 · 2 comments

Comments

@Wangmmx
Copy link

Wangmmx commented Jul 19, 2023

After upgrade, the fee info is always 0 urune in txBody in this api:
Is this a bug?
https://thornode.ninerealms.com/cosmos/tx/v1beta1/txs/E070DD5C81CFA80A5420FD583B73706F13178CF43F8ACFD3FB598C09A82EFEC7

"fee": {
    "amount": [
        {
            "denom": "urune",
            "amount": "0"
        }
    ],
    "granter": "",
    "payer": "",
    "gas_limit": "80000000"
},
@Multipartite
Copy link
Contributor

Maybe ask in GitLab; these links (their discussion threads) are particularly relevant, I think.

https://gitlab.com/thorchain/thornode/-/issues/1582

https://gitlab.com/thorchain/thornode/-/merge_requests/2992#note_1465996803

"don't think we should compute/store it if its not going to be used"

(I will also check by asking there just in case.)

@Wangmmx
Copy link
Author

Wangmmx commented Jul 21, 2023

Thanks to your reply

But it does not make sense, because there was fee in body before, but now it is gone. The impact of the upgrade should be notified in advance. You don’t need to store it, but the information on the chain must be accurate. There is no value in the api, but the browser shows it. This is inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants