Bios Setup knobs not able to retain the default value (Bugzilla Bug 4857)

[tianocore-issues]

This issue was created automatically with bugzilla2github

Bugzilla Bug 4857

Date: 2024-09-30T05:06:01+00:00
From: nikhil.p.sheshagiri
To: nikhil.p.sheshagiri
CC: @lgao4, nigil.kuniyil

Last updated: 2024-10-27T21:44:14+00:00

[tianocore-issues]

Comment 23414

Date: 2024-09-30 05:06:01 +0000
From: nikhil.p.sheshagiri

• Industry Specification: ---
• Release Observed: EDK II Master
• Releases to Fix: EDK II Master
• Target OS: ---
• Bugzilla Assignee(s): nikhil.p.sheshagiri

Bios Setup knobs not able to retain the Sku specific default configuration values after pressing the Load Defaults hot key from the Bios Setup page.

The Header format of the NVvariables generated from the HiiPcd are all in AUTHENTICATED_HEADER format.

So FindVariableData function from HiiDatabaseDxe driver which searches for those variables was still using the old un-authenticted header format to search for the data. Hence was not able to find the correct data.

[tianocore-issues]

Comment 23485

Date: 2024-10-23 20:57:30 +0000
From: @lgao4

[email protected]: please provide the detail how to produce this problem.

[tianocore-issues]

Comment 23492

Date: 2024-10-24 02:11:54 +0000
From: nikhil.p.sheshagiri

[email protected] :
So according to our discussion over mail.
When all the variables in the PcdNvStoreDefaultValueBuffer have the data format as normal variable storage then the current implementation is ok.

But when PcdNvStoreDefaultValueBuffer has variables with data format of the type Authenticated variable storage then current implementation doesn't support this.

Due to change in the header format, it was not able to find the variable data.
So NVS need to support both authenticated and non-authenticated header for NV region.

You can reproduce this issue by changing the variable header format from VARIABLE_HEADER to AUTHENTICATED_VARIABLE_HEADER.

[tianocore-issues]

Comment 23493

Date: 2024-10-24 02:24:35 +0000
From: nikhil.p.sheshagiri

[email protected]:

VPD_AUTHENTICATED_VARIABLE_STORE
if we enable this then the variable header format will be changed from VARIABLE_HEADER to AUTHENTICATED_VARIABLE_HEADER.

[tianocore-issues]

Comment 23498

Date: 2024-10-25 02:35:16 +0000
From: @lgao4

Could you let me know why need to enable VPD_AUTHENTICATED_VARIABLE_STORE?

[tianocore-issues]

Comment 23500

Date: 2024-10-25 04:21:44 +0000
From: nigil.kuniyil

No need to enable VPD_AUTHENTICATED_VARIABLE_STORE. AUTHENTICATED_HEADER is expected to work without any issues with and without this change. As we need to support VPD_AUTHENTICATED_VARIABLE_STORE also for edk2 we need this change also for complete functionality,

[tianocore-issues]

Comment 23501

Date: 2024-10-27 15:06:54 +0000
From: nikhil.p.sheshagiri

[email protected]:
Hi Liming hope you got the clarification, you need anything else ??

[tianocore-issues]

Comment 23502

Date: 2024-10-27 21:42:49 +0000
From: @lgao4

[email protected] is working on it.

[tianocore-issues]

Comment 23503

Date: 2024-10-27 21:44:14 +0000
From: @lgao4

I understand this change. It is to match the condition when VPD_AUTHENTICATED_VARIABLE_STORE is set TRUE. I am OK for this change.