Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsdp with gradient checkpointing #32

Closed
LifuWang-66 opened this issue Jul 15, 2024 · 1 comment
Closed

fsdp with gradient checkpointing #32

LifuWang-66 opened this issue Jul 15, 2024 · 1 comment

Comments

@LifuWang-66
Copy link

Hi Tianwei,

When I create an accelerate config file, it asked "Do you want to enable FSDP activation checkpointing?". I assume it meant that fsdp is compatible with gradient checkpointing. Why is it not supported in DMD2?

Thanks for your help!

@tianweiy
Copy link
Owner

tianweiy commented Jul 15, 2024

this one is only a flag. we also need to modify the code to support it. Some discussions are in #23 (comment)

However, DMD training is a little complex with different optimizers / models updated at different frequencies and some models running in a no_grad mode. This would make implementing the correct logic for gradient accumulation a little challenging. Therefore we don't have the bandwidth to look into this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants