Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc fixes #12

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Minor doc fixes #12

merged 1 commit into from
Nov 8, 2023

Conversation

mattwarkentin
Copy link
Contributor

@mattwarkentin mattwarkentin commented Jul 26, 2023

Hi @topepo,

Just a few minor fixes I noticed when playing around with this package. Hope it is helpful.

For the list -> vector change, it turns out categories can't be a list because it fails check_unit_range(), specifically:

if (!is.vector(x) || !is.numeric(x)) {

@mattwarkentin
Copy link
Contributor Author

Pretty confident that single Windows failure is unrelated to this PR...😬

@topepo
Copy link
Member

topepo commented Nov 8, 2023

Thanks!

@topepo topepo merged commit 03f853e into tidymodels:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants