add toggle_sparsity()
#281
Open
+79
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
commented
Jan 15, 2025
| all(res$allow_sparse_x[res$engine == x$engine]) | ||
| } | ||
|
|
||
| pred_log_fold <- function(sparsity, model, n_rows) { |
There was a problem hiding this comment.
This is generated from a mars model, using sparsity, model and n_rows from https://github.com/tidymodels/benchmark-sparsity-threshold
There was a problem hiding this comment.
I'm not married to this specific model. I'm fine with fine-tuning a little more. but it works fine as is
EmilHvitfeldt
commented
Jan 15, 2025
Comment on lines
+43
to
+45
| if (is.null(model) || model == "ranger") { | ||
| return("no") | ||
| } |
There was a problem hiding this comment.
since ranger performs identically for both sparse and dense data, we turn off automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to close #271
I think this is the last puzzle piece to make sparsity useful in tidymodels.
This will toggle the sparsity creation of recipes based on whether or not we estimate it will be useful or not.