We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify_image_links()
The function that is supposed to simplify the image strings expects strings of the form ![](https://i.imgur.com/woc4vHs.png).
![](https://i.imgur.com/woc4vHs.png)
reprex/R/reprex_render.R
Lines 335 to 339 in 07cd5d7
If this was the input, the code would work fine
x <- "![](https://i.imgur.com/woc4vHs.png)" sub("(^!\\[\\]\\()(.+)(\\)$)", "\\2", x, perl = TRUE) #> [1] "https://i.imgur.com/woc4vHs.png"
However, the actual input includes empty html strings and has the form ![](https://i.imgur.com/woc4vHs.png)<!-- -->
![](https://i.imgur.com/woc4vHs.png)<!-- -->
In this case, the function fails to simplify the link
x <- "![](https://i.imgur.com/woc4vHs.png)<!-- -->" sub("(^!\\[\\]\\()(.+)(\\)$)", "\\2", x, perl = TRUE) #> [1] "![](https://i.imgur.com/woc4vHs.png)<!-- -->"
The result is that links aren't simplified when doing reprex(venue = "slack") as the below example shows (I put the image link in backticks)
reprex(venue = "slack")
library(ggplot2) ggplot(mtcars, aes(disp, qsec)) + geom_point()
![](https://i.imgur.com/9hBJEWw.png)<!-- -->
The text was updated successfully, but these errors were encountered:
fix simplify_image_links (see tidyverse#473)
242fa8c
venue = "discord"
Successfully merging a pull request may close this issue.
The function that is supposed to simplify the image strings expects strings of the form
![](https://i.imgur.com/woc4vHs.png)
.reprex/R/reprex_render.R
Lines 335 to 339 in 07cd5d7
If this was the input, the code would work fine
However, the actual input includes empty html strings and has the form
![](https://i.imgur.com/woc4vHs.png)<!-- -->
In this case, the function fails to simplify the link
The result is that links aren't simplified when doing
reprex(venue = "slack")
as the below example shows (I put the image link in backticks)![](https://i.imgur.com/9hBJEWw.png)<!-- -->
The text was updated successfully, but these errors were encountered: